Skip to contentSkip to conversation

omap_hsmmc: card detect irq bugfix

PATCH In review David Brownell 3 participants 5 messages Feb 4, 2009 – Feb 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap_hsmmc: card detect irq bugfix

From: David Brownell <[email protected]>

Work around lockdep issue when card detect IRQ handlers run in thread context ... it forces IRQF_DISABLED, which prevents all access to twl4030 card detect signals.

---
 drivers/mmc/host/omap_hsmmc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/host/omap_hsmmc.c +3 -1
@@ -517,6 +517,9 @@ static void mmc_omap_detect(struct work_
 {
 	struct mmc_omap_host *host = container_of(work, struct mmc_omap_host,
 						mmc_carddetect_work);
+	struct omap_mmc_slot_data *slot = &mmc_slot(host);
+
+	host->carddetect = slot->card_detect(slot->card_detect_irq);
 
 	sysfs_notify(&host->mmc->class_dev.kobj, NULL, "cover_switch");
 	if (host->carddetect) {
@@ -538,7 +541,6 @@ static irqreturn_t omap_mmc_cd_handler(i
 {
 	struct mmc_omap_host *host = (struct mmc_omap_host *)dev_id;
 
-	host->carddetect = mmc_slot(host).card_detect(irq);
 	schedule_work(&host->mmc_carddetect_work);
 
 	return IRQ_HANDLED;
#1 lore raw
Quoted 8 lines · On Wed, 4 Feb 2009 14:42:03 -0800 David Brownell <[email protected]> wrote:

From: David Brownell <[email protected]>

Work around lockdep issue when card detect IRQ handlers run in thread context ... it forces IRQF_DISABLED, which prevents all access to twl4030 card detect signals.

---

An ack from eiter Tony or one of the listed authors of this driver would be nice.

Rgds

Signature · 9 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
Acked-by
#2 lore raw
Quoted 9 lines · Pierre Ossman
Quoted 6 lines · On Wed, 4 Feb 2009 14:42:03 -0800 David Brownell <[email protected]> wrote:

From: David Brownell <[email protected]>

Work around lockdep issue when card detect IRQ handlers run in thread context ... it forces IRQF_DISABLED, which prevents all access to twl4030 card detect signals.

Quoted 5 lines
Quoted 2 lines

---

An ack from eiter Tony or one of the listed authors of this driver would be nice.

Here you are:

Regards,

Tony

#3 lore raw
Quoted 13 lines · On Tue, 17 Feb 2009 22:13:59 -0800 Tony Lindgren <[email protected]> wrote:
Quoted 12 lines · Pierre Ossman
Quoted 8 lines · On Wed, 4 Feb 2009 14:42:03 -0800 David Brownell <[email protected]> wrote:

From: David Brownell <[email protected]>

Work around lockdep issue when card detect IRQ handlers run in thread context ... it forces IRQF_DISABLED, which prevents all access to twl4030 card detect signals.

---

Quoted 7 lines
Quoted 2 lines

An ack from eiter Tony or one of the listed authors of this driver would be nice.

Here you are:

Queued. Could you have a look at the other omap_hsmmc patches as well? And a patch for MAINTAINERS so that I can keep track of who's baby this is. :)

Rgds

Signature · 9 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
#4 lore raw
Quoted 19 lines · Pierre Ossman
Quoted 16 lines · On Tue, 17 Feb 2009 22:13:59 -0800 Tony Lindgren <[email protected]> wrote:
Quoted 14 lines · Pierre Ossman
Quoted 8 lines · On Wed, 4 Feb 2009 14:42:03 -0800 David Brownell <[email protected]> wrote:

From: David Brownell <[email protected]>

Work around lockdep issue when card detect IRQ handlers run in thread context ... it forces IRQF_DISABLED, which prevents all access to twl4030 card detect signals.

---

An ack from eiter Tony or one of the listed authors of this driver would be nice.

Quoted 8 lines
Quoted 4 lines

Here you are:

Queued. Could you have a look at the other omap_hsmmc patches as well? And a patch for MAINTAINERS so that I can keep track of who's baby this is. :)

Thanks. We've been meaning to add some omap maintainers for some time now, so I'll do a patch that adds an entries to MAINTAINERS for most omap drivers and will post it to all the associated mailing lists.

Regards,

Tony