Skip to contentSkip to conversation

tridentfb: fix memory leaks in removal path

PATCH In review Andres Salomon 2 participants 2 messages Feb 7, 2009 – Feb 8, 2009 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 3/15 tridentfb: fix memory leaks in removal path

We were leaking the cmap memory.

---
 drivers/video/tridentfb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/tridentfb.c +1 -0
index 479b2e7..c5369ba 100644
@@ -1563,6 +1563,7 @@ static void __devexit trident_pci_remove(struct pci_dev *dev)
 	release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
 	pci_set_drvdata(dev, NULL);
 	kfree(info->pixmap.addr);
+	fb_dealloc_cmap(&info->cmap);
 	framebuffer_release(info);
 }
 
Signature · 9 lines
1.5.6.5


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
Acked-by on v1 3/15
#1 lore raw
Quoted 5 lines · On Sat, 7 Feb 2009 12:12:33 -0500 Andres Salomon <[email protected]> wrote:

We were leaking the cmap memory.

---

Quoted 8 lines
 drivers/video/tridentfb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/tridentfb.c +0 -0
index 479b2e7..c5369ba 100644

drivers/video/tridentfb.c static void __devexit trident_pci_remove(struct pci_dev *dev) · line 1569

Quoted 7 lines
drivers/video/tridentfb.c +1 -0
@@ -1563,6 +1563,7 @@ static void __devexit trident_pci_remove(struct pci_dev *dev)
 	release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
 	pci_set_drvdata(dev, NULL);
 	kfree(info->pixmap.addr);
+	fb_dealloc_cmap(&info->cmap);
 	framebuffer_release(info);
 }
 

----------------------------------------------------------------------
Zostan mistrzem parkowania w Bombaju!
Zagraj >> http://link.interia.pl/f204e

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com