ALSA: hda - Cleanup setting of pin_configs in patch_stac927x
PATCH 1/1 ALSA: hda - Cleanup setting of pin_configs in patch_stac927x
After commit "ALSA: hda - Fix restore of pin configs at resume for STAC/IDT codecs", the introduced stac_save_pin_cfgs function checks already for pins == NULL case, saving then default pin configs from machine with stac92xx_save_bios_config_regs. So we can remove the extra checks when stac927x_brd_tbl[spec->board_config] == NULL.
--- sound/pci/hda/patch_sigmatel.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
sound/pci/hda/patch_sigmatel.c +3 -4
@@ -5292,10 +5292,9 @@ static int patch_stac927x(struct hda_codec *codec) stac927x_models, stac927x_cfg_tbl); again: -if (spec->board_config <0 || !stac927x_brd_tbl[spec->board_config]) { -if (spec->board_config <0 ) -snd_printdd (KERN_INFO "hda_codec: Unknown model for" -"STAC927x, using BIOS defaults\n" ); +if (spec->board_config <0 ) { +snd_printdd (KERN_INFO "hda_codec: Unknown model for" +"STAC927x, using BIOS defaults\n" ); err =stac92xx_save_bios_config_regs (codec); }else err = stac_save_pin_cfgs(codec,
Signature · 1 line
1.6.1.3
At Wed, 11 Feb 2009 20:33:15 -0200,
Quoted 8 lines · Herton Ronaldo Krzesinski
After commit "ALSA: hda - Fix restore of pin configs at resume for STAC/IDT codecs", the introduced
stac_save_pin_cfgsfunction checks already for pins == NULL case, saving then default pin configs from machine withstac92xx_save_bios_config_regs. So we can remove the extra checks when stac927x_brd_tbl[spec->board_config] == NULL.Signed-off-by Herton Ronaldo Krzesinski <[email protected]>
Applied now. Thanks.
Takashi
Quoted 30 lines
--- sound/pci/hda/patch_sigmatel.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)sound/pci/hda/patch_sigmatel.c +3
-4@@ -5292,10 +5292,9 @@ static int patch_stac927x(struct hda_codec *codec) stac927x_models, stac927x_cfg_tbl); again: -if (spec->board_config <0 || !stac927x_brd_tbl[spec->board_config]) { -if (spec->board_config <0 ) -snd_printdd (KERN_INFO "hda_codec: Unknown model for" -"STAC927x, using BIOS defaults\n" ); +if (spec->board_config <0 ) { +snd_printdd (KERN_INFO "hda_codec: Unknown model for" +"STAC927x, using BIOS defaults\n" ); err =stac92xx_save_bios_config_regs (codec); }else err = stac_save_pin_cfgs(codec,Signature · 6 lines
1.6.1.3 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel