Skip to contentSkip to conversation

Staging: pohmelfs should depend on CRYPTO

PATCH In review Alexander Beregalov 2 participants 3 messages Feb 13, 2009 – Feb 14, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: pohmelfs should depend on CRYPTO

---

 drivers/staging/pohmelfs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/pohmelfs/Kconfig +1 -0
index f150ecb..4c6276b 100644
@@ -1,6 +1,7 @@
 config POHMELFS
 	tristate "POHMELFS filesystem support"
 	select CONNECTOR
+	select CRYPTO
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_HMAC
 	help
#1 lore raw
Quoted 3 lines · Alexander Beregalov

Doesn't subsystem selection also forces higher level selection, i.e. selecing CRYPTO_BLKCIPHER also forces CRYPTO selection? If it is not the case, then your patch is definitely valid.

Quoted 17 lines

---

 drivers/staging/pohmelfs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/pohmelfs/Kconfig +1 -0
index f150ecb..4c6276b 100644
@@ -1,6 +1,7 @@
 config POHMELFS
 	tristate "POHMELFS filesystem support"
 	select CONNECTOR
+	select CRYPTO
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_HMAC
 	help
Signature · 1 line
	Evgeniy Polyakov
#2 lore raw

2009/2/14 Evgeniy Polyakov <[email protected]>:

Quoted 8 lines · Alexander Beregalov
Quoted 3 lines

Doesn't subsystem selection also forces higher level selection, i.e. selecing CRYPTO_BLKCIPHER also forces CRYPTO selection? If it is not the case, then your patch is definitely valid.

No, it does not. The kernel fails to build if CRYPTO was disabled before enabling POHMELFS.

Quoted 22 lines
Quoted 11 lines

---

 drivers/staging/pohmelfs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/pohmelfs/Kconfig +0 -0
index f150ecb..4c6276b 100644

drivers/staging/pohmelfs/Kconfig line 7

Quoted 7 lines
drivers/staging/pohmelfs/Kconfig +1 -0
@@ -1,6 +1,7 @@
 config POHMELFS
      tristate "POHMELFS filesystem support"
      select CONNECTOR
+     select CRYPTO
      select CRYPTO_BLKCIPHER
      select CRYPTO_HMAC
      help

--
Evgeniy Polyakov