Skip to contentSkip to conversation

ip: add loose reverse path filtering

PATCH In review Stephen Hemminger 3 participants 5 messages Feb 20, 2009 – Feb 23, 2009

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ip: add loose reverse path filtering

Extend existing reverse path filter option to allow strict or loose filtering. (See http://en.wikipedia.org/wiki/Reverse_path_filtering).

For compatibility with existing usage, the value 1 is chosen for strict mode and 2 for loose mode.

---
 Documentation/networking/ip-sysctl.txt |   22 ++++++++++++++--------
 net/ipv4/fib_frontend.c                |    2 +-
 2 files changed, 15 insertions(+), 9 deletions(-)
Documentation/networking/ip-sysctl.txt +14 -8
@@ -699,16 +699,22 @@ accept_source_route - BOOLEAN
 	default TRUE (router)
 		FALSE (host)
 
-rp_filter - BOOLEAN
-	1 - do source validation by reversed path, as specified in RFC1812
-	    Recommended option for single homed hosts and stub network
-	    routers. Could cause troubles for complicated (not loop free)
-	    networks running a slow unreliable protocol (sort of RIP),
-	    or using static routes.
-
+rp_filter - INTEGER
 	0 - No source validation.
+	1 - Strict mode as defined in RFC3704 Strict Reverse Path
+	    Each incoming packet is tested against the FIB and if the interface
+	    is not the best reverse path the packet check will fail.
+	    By default failed packets are discarded.
+	2 - Loose mode as defined in RFC3704 Loose Reverse Path
+	    Each incoming packet's source address is also tested against the FIB
+	    and if the source address is not reachable via any interface
+	    the packet check will fail.
+
+        Current recommended practice in RFC3704 is to enable strict mode
+	to prevent IP spoofin from DDos attacks. If using asymmetric routing
+        or other complicated routing,t hen loose mode is recommended.
 
-	conf/all/rp_filter must also be set to TRUE to do source validation
+	conf/all/rp_filter must also be set to non-zero to do source validation
 	on the interface
 
 	Default value is 0. Note that some distributions enable it
net/ipv4/fib_frontend.c +1 -1
@@ -275,7 +275,7 @@ int fib_validate_source(__be32 src, __be
 	fib_res_put(&res);
 	if (no_addr)
 		goto last_resort;
-	if (rpf)
+	if (rpf == 1)
 		goto e_inval;
 	fl.oif = dev->ifindex;
 
#1 lore raw
Quoted 7 lines · Stephen Hemminger

Extend existing reverse path filter option to allow strict or loose filtering. (See http://en.wikipedia.org/wiki/Reverse_path_filtering).

For compatibility with existing usage, the value 1 is chosen for strict mode and 2 for loose mode.

Rather than extending the rp_filter stuff any further, I'd prefer to see this replaced with netfilter plugin.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer
#2 lore raw

From: Herbert Xu <[email protected]>
Date: Sat, 21 Feb 2009 21:09:07 +0800

Quoted 11 lines
Quoted 7 lines · Stephen Hemminger

Extend existing reverse path filter option to allow strict or loose filtering. (See http://en.wikipedia.org/wiki/Reverse_path_filtering).

For compatibility with existing usage, the value 1 is chosen for strict mode and 2 for loose mode.

Rather than extending the rp_filter stuff any further, I'd prefer to see this replaced with netfilter plugin.

Normally I would agree, but in this case the cost is exactly zero for the added flexibility.

So I'll apply this to net-next-2.6

#3 lore raw
Quoted 6 lines · David Miller
Quoted 3 lines

Rather than extending the rp_filter stuff any further, I'd prefer to see this replaced with netfilter plugin.

Normally I would agree, but in this case the cost is exactly zero for the added flexibility.

Ah I thought there was another patch coming :) But obviously as this is all that's needed for it sure it looks good to me too.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#4 lore raw
Quoted 5 lines · On Sun, 22 Feb 2009 16:34:36 +0800 Herbert Xu <[email protected]>…
Quoted 4 lines · David Miller
Quoted 3 lines

Rather than extending the rp_filter stuff any further, I'd prefer to see this replaced with netfilter plugin.

Quoted 7 lines
Quoted 2 lines

Normally I would agree, but in this case the cost is exactly zero for the added flexibility.

Ah I thought there was another patch coming :) But obviously as this is all that's needed for it sure it looks good to me too.

Cheers,

Also, the purpose of reverse path filtering is to block Dos attacks. So it is important to do any rejection with least overhead. If the filter is iptables rules, it takes longer and requires another route lookup.