drivers/isdn: fix sparse warnings
Subsystems (3)
cover drivers/isdn: fix sparse warnings
The following series fixes some sparse warnings in drivers/isdn.
---
Hannes Eder (5):
drivers/isdn/hardware/eicon: fix sparse warnings: Should it be static? drivers/isdn/hardware/icon: fix sparse warning: cast truncates bits drivers/isdn/hisax: fix sparse warning: Should it be static? drivers/isdn/act2000: fix sparse warning: symbol shadows an earlier one drivers/isdn/capi: fix sparse warning: context imbalance
drivers/isdn/act2000/act2000_isa.c | 6 +-- drivers/isdn/capi/kcapi_proc.c | 2 + drivers/isdn/hardware/eicon/debug.c | 2 - drivers/isdn/hardware/eicon/message.c | 70 ++++++++++++++++++++++----------- drivers/isdn/hisax/callc.c | 1 drivers/isdn/hisax/config.c | 6 --- drivers/isdn/hisax/hfcscard.c | 2 - drivers/isdn/hisax/hisax.h | 9 ++++ drivers/isdn/hisax/isdnl1.c | 4 +- drivers/isdn/hisax/sedlbauer.c | 2 - drivers/isdn/hisax/teles0.c | 2 - drivers/isdn/hisax/teles3.c | 1 12 files changed, 63 insertions(+), 44 deletions(-)
PATCH 1/5 drivers/isdn/capi: fix sparse warning: context imbalance
Impact: Attribute functions with __acquires(...) resp. __releases(...).
Fix this sparse warnings:
drivers/isdn/capi/kcapi_proc.c:241:13: warning: context imbalance in 'capi_driver_start' - wrong count at exit drivers/isdn/capi/kcapi_proc.c:252:13: warning: context imbalance in 'capi_driver_stop' - unexpected unlock
--- drivers/isdn/capi/kcapi_proc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/isdn/capi/kcapi_proc.c +2 -0
@@ -239,6 +239,7 @@ static const struct file_operations proc_applstats_ops = {// --------------------------------------------------------------------------- static void *capi_driver_start (struct seq_file *seq,loff_t *pos) + __acquires(&capi_drivers_list_lock) {read_lock (&capi_drivers_list_lock);return seq_list_start (&capi_drivers, *pos);
@@ -250,6 +251,7 @@ static void *capi_driver_next(struct seq_file *seq, void *v, loff_t *pos) }static void capi_driver_stop (struct seq_file *seq,void *v) + __releases(&capi_drivers_list_lock) {read_unlock (&capi_drivers_list_lock); }
PATCH 2/5 drivers/isdn/act2000: fix sparse warning: symbol shadows an earlier one
In reply to Hannes EderImpact: Rename local variable 'c' to 't'.
Fix this sparse warning:
drivers/isdn/act2000/act2000_isa.c:260:70: warning: symbol 'c' shadows an earlier one
---
The lines are overlong, but the whole function would need a good reformating / refactoring in order to obey the 80 character limit.
drivers/isdn/act2000/act2000_isa.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/isdn/act2000/act2000_isa.c +3 -3
@@ -257,9 +257,9 @@ act2000_isa_receive(act2000_card *card)printk (KERN_WARNING "act2000_isa_receive: Invalid CAPI msg\n" ); { -int i;__u8 *p;__u8 *c;__u8 tmp[30 ]; -for (i =0 , p = (__u8 *)&card->idat.isa.rcvhdr, c = tmp; i <8 ; i++) - c +=sprintf (c,"%02x " , *(p++)); +int i;__u8 *p;__u8 *t;__u8 tmp[30 ]; +for (i =0 , p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i <8 ; i++) + t +=sprintf (t,"%02x " , *(p++));printk (KERN_WARNING "act2000_isa_receive: %s\n" , tmp); } }
PATCH 3/5 drivers/isdn/hisax: fix sparse warning: Should it be static?
In reply to Hannes EderImpact: Move declarations to a header file.
Fix this sparse warning:
drivers/isdn/hisax/callc.c:24:12: warning: symbol 'lli_revision' was not declared. Should it be static? drivers/isdn/hisax/config.c:84:12: warning: symbol 'CardType' was not declared. Should it be static? drivers/isdn/hisax/config.c:362:5: warning: symbol 'nrcards' was not declared. Should it be static? drivers/isdn/hisax/isdnl1.c:21:12: warning: symbol 'l1_revision' was not declared. Should it be static? drivers/isdn/hisax/isdnl2.c:22:12: warning: symbol 'l2_revision' was not declared. Should it be static? drivers/isdn/hisax/isdnl3.c:22:12: warning: symbol 'l3_revision' was not declared. Should it be static? drivers/isdn/hisax/tei.c:23:12: warning: symbol 'tei_revision' was not declared. Should it be static?
---
How to deal with this checkpatch.pl warning?
Quoted 3 lines
WARNING: CVS style keyword markers, these will _not_ be updated #104: FILE:
drivers/isdn/hisax/isdnl1.c:25:
+const char*l1_revision= "$Revision: 2.46.2.5 $";
drivers/isdn/hisax/callc.c | 1 - drivers/isdn/hisax/config.c | 6 ------ drivers/isdn/hisax/hfcscard.c | 2 -- drivers/isdn/hisax/hisax.h | 9 +++++++++ drivers/isdn/hisax/isdnl1.c | 4 ++-- drivers/isdn/hisax/sedlbauer.c | 2 -- drivers/isdn/hisax/teles0.c | 2 -- drivers/isdn/hisax/teles3.c | 1 - 8 files changed, 11 insertions(+), 16 deletions(-)
drivers/isdn/hisax/callc.c +0 -1
@@ -24,7 +24,6 @@const char *lli_revision ="$Revision: 2.59.2.4 $" ;extern struct IsdnCard cards[]; -extern int nrcards;static int init_b_st (struct Channel *chanp,int incoming);static void release_b_st (struct Channel *chanp);
drivers/isdn/hisax/config.c +0 -6
@@ -361,12 +361,6 @@ module_param_array(io1, int, NULL, 0);int nrcards; -extern const char *l1_revision; -extern const char *l2_revision; -extern const char *l3_revision; -extern const char *lli_revision; -extern const char *tei_revision; -char *HiSax_getrev (const char *revision) {char *rev;
drivers/isdn/hisax/hfcscard.c +0 -2
@@ -16,8 +16,6 @@#include "hfc_2bds0.h" #include "isdnl1.h" -extern const char *CardType[]; -static const char *hfcs_revision ="$Revision: 1.10.2.4 $" ; static irqreturn_t
drivers/isdn/hisax/hisax.h +9 -0
@@ -121,6 +121,15 @@#ifdef __KERNEL__ +extern const char *CardType[]; +extern int nrcards; + +extern const char *l1_revision; +extern const char *l2_revision; +extern const char *l3_revision; +extern const char *lli_revision; +extern const char *tei_revision; +/* include l3dss1 & ni1 specific process structures, but no other defines */ #ifdef CONFIG_HISAX_EURO #define l3dss1_process
drivers/isdn/hisax/isdnl1.c +2 -2
@@ -18,12 +18,12 @@* */ -const char *l1_revision ="$Revision: 2.46.2.5 $" ; -#include <linux/init.h> #include "hisax.h" #include "isdnl1.h" +const char *l1_revision ="$Revision: 2.46.2.5 $" ; +#define TIMER3_VALUE 7000static struct Fsm l1fsm_b;
drivers/isdn/hisax/sedlbauer.c +0 -2
@@ -48,8 +48,6 @@#include <linux/pci.h> #include <linux/isapnp.h> -extern const char *CardType[]; -static const char *Sedlbauer_revision ="$Revision: 1.34.2.6 $" ; static const char *Sedlbauer_Types[] diff --git a/drivers/isdn/hisax/teles0.c b/drivers/isdn/hisax/teles0.c
index 4858133..3ca0bed 100644
drivers/isdn/hisax/teles0.c +0 -2
@@ -21,8 +21,6 @@#include "isac.h" #include "hscx.h" -extern const char *CardType[]; -static const char *teles0_revision ="$Revision: 2.15.2.4 $" ;#define TELES_IOMEM_SIZE 0x400
drivers/isdn/hisax/teles3.c +0 -1
@@ -20,7 +20,6 @@#include "hscx.h" #include "isdnl1.h" -extern const char *CardType[];static const char *teles3_revision ="$Revision: 2.19.2.4 $" ;#define byteout (addr,val) outb(val,addr)
PATCH 4/5 drivers/isdn/hardware/icon: fix sparse warning: cast truncates bits
In reply to Hannes EderFix this sparse warning:
drivers/isdn/hardware/eicon/debug.c:1201:32: warning: cast truncates bits from constant value (1000 becomes 0)
--- drivers/isdn/hardware/eicon/debug.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/isdn/hardware/eicon/debug.c +1 -1
@@ -1198,7 +1198,7 @@ int SuperTraceASSIGN (void* AdapterHandle, byte* data) { pC->xbuffer[5 ] = (byte)(rx_dma_magic >>8 ); pC->xbuffer[6 ] = (byte)(rx_dma_magic >>16 ); pC->xbuffer[7 ] = (byte)(rx_dma_magic >>24 ); - pC->xbuffer[8 ] = (byte )DIVA_MAX_MANAGEMENT_TRANSFER_SIZE ; + pC->xbuffer[8 ] = (byte)(DIVA_MAX_MANAGEMENT_TRANSFER_SIZE &0xFF ); pC->xbuffer[9 ] = (byte)(DIVA_MAX_MANAGEMENT_TRANSFER_SIZE >>8 ); pC->xbuffer[10 ] =0 ;
PATCH 5/5 drivers/isdn/hardware/eicon: fix sparse warnings: Should it be static?
In reply to Hannes EderImpact: Make symbols static.
Fix this sparse warnings:
drivers/isdn/hardware/eicon/message.c:1197:6: warning: symbol 'connect_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1414:6: warning: symbol 'connect_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1570:6: warning: symbol 'connect_a_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1576:6: warning: symbol 'disconnect_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1631:6: warning: symbol 'disconnect_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1658:6: warning: symbol 'listen_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1707:6: warning: symbol 'info_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1816:6: warning: symbol 'info_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1822:6: warning: symbol 'alert_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:1852:6: warning: symbol 'facility_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:2602:6: warning: symbol 'facility_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:2608:6: warning: symbol 'connect_b3_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:2842:6: warning: symbol 'connect_b3_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:2957:6: warning: symbol 'connect_b3_a_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:2977:6: warning: symbol 'disconnect_b3_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3033:6: warning: symbol 'disconnect_b3_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3089:6: warning: symbol 'data_b3_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3166:6: warning: symbol 'data_b3_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3199:6: warning: symbol 'reset_b3_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3240:6: warning: symbol 'reset_b3_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3264:6: warning: symbol 'connect_b3_t90_a_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3298:6: warning: symbol 'select_b_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8692:6: warning: symbol 'sig_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8792:6: warning: symbol 'send_data' was not declared. Should it be static?
--- drivers/isdn/hardware/eicon/message.c | 70 ++++++++++++++++++++++----------- 1 files changed, 46 insertions(+), 24 deletions(-)
drivers/isdn/hardware/eicon/message.c +46 -24
@@ -1194,7 +1194,8 @@ static char hex_digit_table[0x10] /* translation function for each message *//*------------------------------------------------------------------*/ -byte connect_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte connect_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word ch;word i;
@@ -1411,7 +1412,8 @@ byte connect_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return 2 ; } -byte connect_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte connect_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word i, Info;word Reject;
@@ -1567,13 +1569,15 @@ byte connect_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return 1 ; } -byte connect_a_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte connect_a_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {dbug (1 ,dprintf ("connect_a_res" ));return false; } -byte disconnect_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte disconnect_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {word Info;word i;
@@ -1628,7 +1632,8 @@ byte disconnect_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plcreturn false; } -byte disconnect_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte disconnect_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {dbug (1 ,dprintf ("disconnect_res" ));if (plci)
@@ -1655,7 +1660,8 @@ byte disconnect_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plcreturn 0 ; } -byte listen_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte listen_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word Info;byte i;
@@ -1704,7 +1710,8 @@ byte listen_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci, Areturn false; } -byte info_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte info_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {word i;API_PARSE * ai;
@@ -1813,13 +1820,15 @@ byte info_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci, APPreturn false; } -byte info_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte info_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {dbug (1 ,dprintf ("info_res" ));return false; } -byte alert_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte alert_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {word Info;byte ret;
@@ -1849,7 +1858,8 @@ byte alert_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci, APreturn ret; } -byte facility_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte facility_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {word Info =0 ;word i =0 ;
@@ -2599,13 +2609,15 @@ byte facility_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return false; } -byte facility_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte facility_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {dbug (1 ,dprintf ("facility_res" ));return false; } -byte connect_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte connect_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word Info =0 ;byte req;
@@ -2839,7 +2851,8 @@ byte connect_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plcreturn false; } -byte connect_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte connect_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word ncci;API_PARSE * ncpi;
@@ -2954,7 +2967,8 @@ byte connect_b3_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plcreturn false; } -byte connect_b3_a_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte connect_b3_a_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word ncci;
@@ -2974,7 +2988,8 @@ byte connect_b3_a_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * preturn false; } -byte disconnect_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte disconnect_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word Info;word ncci;
@@ -3030,7 +3045,8 @@ byte disconnect_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI *return false; } -byte disconnect_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte disconnect_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word ncci;word i;
@@ -3086,7 +3102,8 @@ byte disconnect_b3_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI *return false; } -byte data_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte data_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {NCCI *ncci_ptr;DATA_B3_DESC *data;
@@ -3163,7 +3180,8 @@ byte data_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return false; } -byte data_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte data_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word n;word ncci;
@@ -3196,7 +3214,8 @@ byte data_b3_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return false; } -byte reset_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte reset_b3_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word Info;word ncci;
@@ -3237,7 +3256,8 @@ byte reset_b3_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return false; } -byte reset_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte reset_b3_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word ncci;
@@ -3261,7 +3281,8 @@ byte reset_b3_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,return false; } -byte connect_b3_t90_a_res (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * parms) +static byte connect_b3_t90_a_res (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *parms) {word ncci;API_PARSE * ncpi;
@@ -3295,7 +3316,8 @@ byte connect_b3_t90_a_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI } -byte select_b_req (dword Id,word Number,DIVA_CAPI_ADAPTER * a,PLCI * plci,APPL * appl,API_PARSE * msg) +static byte select_b_req (dword Id,word Number,DIVA_CAPI_ADAPTER *a, +PLCI *plci,APPL *appl,API_PARSE *msg) {word Info=0 ;word i;
@@ -8689,7 +8711,7 @@ static word add_modem_b23 (PLCI * plci, API_PARSE* bp_parms)/* send a request for the signaling entity */ /*------------------------------------------------------------------*/ -void sig_req (PLCI * plci,byte req,byte Id) +static void sig_req (PLCI *plci,byte req,byte Id) {if (!plci)return ;if (plci->adapter->adapter_disabled)return ;
@@ -8789,7 +8811,7 @@ static void send_req(PLCI *plci)dbug (1 ,dprintf ("send_ok" )); } -void send_data (PLCI * plci) +static void send_data (PLCI *plci) {DIVA_CAPI_ADAPTER * a;DATA_B3_DESC * data;
From: Hannes Eder <[email protected]>
Date: Thu, 26 Feb 2009 00:08:20 +0100
Quoted 10 lines
The following series fixes some sparse warnings in
drivers/isdn.---
Hannes Eder (5):
drivers/isdn/hardware/eicon: fix sparse warnings: Should it be static?drivers/isdn/hardware/icon: fix sparse warning: cast truncates bitsdrivers/isdn/hisax: fix sparse warning: Should it be static?drivers/isdn/act2000: fix sparse warning: symbol shadows an earlier onedrivers/isdn/capi: fix sparse warning: context imbalance
Applied to net-next-2.6, thanks!