Skip to contentSkip to conversation

ISP: Remove hardcoding of CCDC input offset.

PATCH New Dominic Curran 1 participant 1 message Feb 26, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ISP: Remove hardcoding of CCDC input offset.

From: Dominic Curran <[email protected]>
Subject: [OMAPZOOM][PATCH 1/3] ISP: Remove hardcoding of CCDC input offset.

The Sony IMX046 patch set introduced a bug when setting CCDC input offsets. The Sony patch set the horz & vert offsets to 0.
This worked from the Sony IMX046, but broke settings for other sensors like MT9P012 & OV3640.
The reason is that all three sensors send their data with different component orders.

The effect was to mess up colours in previewer module for MT9P012 & OV3640. This patch reverts that bug.

The other patches in this set will provide a better way of setting these offsets, thus allowing easy setup for any type kind of incoming componenet order.

---
 drivers/media/video/isp/ispccdc.c |    2 --
 1 file changed, 2 deletions(-)
drivers/media/video/isp/ispccdc.c +0 -2
Index: omapzoom04/drivers/media/video/isp/ispccdc.c
===================================================================
@@ -1265,8 +1265,6 @@ int ispccdc_config_size(u32 input_w, u32
 	}
 
 	if (ispccdc_obj.ccdc_outfmt == CCDC_OTHERS_VP) {
-		ispccdc_obj.ccdcin_woffset = 0;
-		ispccdc_obj.ccdcin_hoffset = 0;
 		omap_writel((ispccdc_obj.ccdcin_woffset <<
 					ISPCCDC_FMT_HORZ_FMTSPH_SHIFT) |
 					(ispccdc_obj.ccdcin_w <<