Skip to contentSkip to conversation

mac80211: Replacement for: Implement commit in wireless extensions

PATCH In review Alina Friedrichsen 2 participants 3 messages Feb 27, 2009 mac80211

lore
Share & tools
lore

Alina Friedrichsen

author
#0 lore raw

PATCH 1/1 mac80211: Replacement for: Implement commit in wireless extensions

This patch _not_ implements commit in wireless extensions, but solves s= ome dependencies needed by the other patches.

The maybe usage of this ioctl must discussed after the complete joining=
process (STA and *IBSS*) in nl80211 defined.

I hope this is a compromise.

Signed-off-by Alina Friedrichsen <[email protected]>

---

net/mac80211/ieee80211_i.h +0 -0
index ecbc8e0..7f00c70 100644
@@ -920,6 +920,7 @@ static inline int ieee80211_bssid_match(const u8 *r=

addr, const u8 *addr)
=20
int ieee80211_hw_config(struct ieee80211_local *local, u32 changed); int ieee80211_if_config(struct ieee80211_sub_if_data *sdata, u32 chang=
ed);
+void ieee80211_commit(struct ieee80211_sub_if_data *sdata);
void ieee80211_tx_set_protected(struct ieee80211_tx_data *tx); void ieee80211_bss_info_change_notify(struct ieee80211_sub_if_data *sd=
ata,
u32 changed);

net/mac80211/main.c +0 -0
index f38db4d..1b2d598 100644
@@ -294,6 +294,20 @@ int ieee80211_hw_config(struct ieee80211_local *lo=

cal, u32 changed)
return ret;
}
=20
+void ieee80211_commit(struct ieee80211_sub_if_data *sdata) +{
+ switch (sdata->vif.type) {
+ case NL80211_IFTYPE_ADHOC:
+ ieee80211_ibss_commit(sdata);
+ break;
+ case NL80211_IFTYPE_STATION:
+ ieee80211_sta_commit(sdata);
+ break;
+ default:
+ break;
+ }
+}
+
void ieee80211_bss_info_change_notify(struct ieee80211_sub_if_data *sd=
ata,
u32 changed)
{

--=20
Computer Bild Tarifsieger! GMX FreeDSL - Telefonanschluss + DSL f=FCr nur 17,95 =BF/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T45=
69a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#1 lore raw
Quoted 30 lines · Alina Friedrichsen

This patch _not_ implements commit in wireless extensions, but solves some dependencies needed by the other patches.

The maybe usage of this ioctl must discussed after the complete joining process (STA and *IBSS*) in nl80211 defined.

I hope this is a compromise.

Signed-off-by Alina Friedrichsen <[email protected]>

---

net/mac80211/ieee80211_i.h +1 -0
index ecbc8e0..7f00c70 100644
@@ -920,6 +920,7 @@ static inline int ieee80211_bssid_match(const u8 *raddr, const u8 *addr)
 
 int ieee80211_hw_config(struct ieee80211_local *local, u32 changed);
 int ieee80211_if_config(struct ieee80211_sub_if_data *sdata, u32 changed);
+void ieee80211_commit(struct ieee80211_sub_if_data *sdata);
 void ieee80211_tx_set_protected(struct ieee80211_tx_data *tx);
 void ieee80211_bss_info_change_notify(struct ieee80211_sub_if_data *sdata,
 				      u32 changed);
net/mac80211/main.c +2 -0
index f38db4d..1b2d598 100644
@@ -294,6 +294,20 @@ int ieee80211_hw_config(struct ieee80211_local *local, u32 changed)
 	return ret;
 }
 
+void ieee80211_commit(struct ieee80211_sub_if_data *sdata)
+{

net/mac80211/main.c int ieee80211_hw_config(struct ieee80211_local *local, u32 changed) · line 308

Quoted 10 lines
net/mac80211/main.c +10 -0
+	switch (sdata->vif.type) {
+	case NL80211_IFTYPE_ADHOC:
+		ieee80211_ibss_commit(sdata);
+		break;
+	case NL80211_IFTYPE_STATION:
+		ieee80211_sta_commit(sdata);
+		break;
+	default:
+		break;
+	}

I don't really see a need for that, it's only called in what, two places? And it makes things interdependent. At _least_ put it into a more appropriate file like wext.c and open-code it in cfg.c

johannes

author
#2 lore raw

Hello Johannes!

Quoted 2 lines

I don't really see a need for that, it's only called in what, two places? And it makes things interdependent.

One centralized function is in
every case easier to maintain.
=46or example if you add mesh mode to it.

Quoted 2 lines

At _least_ put it into a
more appropriate file like wext.c

This function is config interface independent,
so wext.c is not the right place for it.

Quoted 1 line

and open-code it in cfg.c

This would be a better place for it
if it should be added to
mac80211_config_ops. If not I think
main.c is the best place for it.

Regards
Alina

--=20
Computer Bild Tarifsieger! GMX FreeDSL - Telefonanschluss + DSL f=FCr nur 17,95 =BF/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T45=
69a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html