ARM: OMAP2: Fix missing system control module exports
Subsystems (3)
PATCH 1/1 ARM: OMAP2: Fix missing system control module exports
When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other) drivers as modules.
--- arch/arm/mach-omap2/control.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/control.c +6 -0
@@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset) {return __raw_readb (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readb);u16 omap_ctrl_readw (u16 offset) {return __raw_readw (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readw);u32 omap_ctrl_readl (u16 offset) {return __raw_readl (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readl);void omap_ctrl_writeb (u8 val,u16 offset) {__raw_writeb (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writeb);void omap_ctrl_writew (u16 val,u16 offset) {__raw_writew (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writew);void omap_ctrl_writel (u32 val,u16 offset) {__raw_writel (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writel);
Signature · 1 line
1.6.1.2.MVISTA
Tony Lindgren
maintainerHi,
Quoted 4 lines · George G. Davis
When building ASoC drivers as modules for
SND_OMAP_SOC_MCBSPbased targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other) drivers as modules.
I think Paul has some comments on how the clock framework should handle this case without needing to export the omap_ctrl_read/write.
Regards,
Tony
Quoted 53 lines
Signed-off-by George G. Davis <[email protected]>Acked-by Jarkko Nikula <[email protected]>--- arch/arm/mach-omap2/control.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)arch/arm/mach-omap2/control.c +6
-0@@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset) {return __raw_readb (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readb);u16 omap_ctrl_readw (u16 offset) {return __raw_readw (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readw);u32 omap_ctrl_readl (u16 offset) {return __raw_readl (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readl);void omap_ctrl_writeb (u8 val,u16 offset) {__raw_writeb (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writeb);void omap_ctrl_writew (u16 val,u16 offset) {__raw_writew (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writew);void omap_ctrl_writel (u32 val,u16 offset) {__raw_writel (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writel);Signature · 6 lines
1.6.1.2.MVISTA -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Quoted 10 lines · Tony Lindgren
Hi,
Quoted 4 lines · George G. Davis
When building ASoC drivers as modules for
SND_OMAP_SOC_MCBSPbased targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other) drivers as modules.I think Paul has some comments on how the clock framework should handle this case without needing to export the omap_ctrl_read/write.
Yeah, I figured direct calls to these from drivers was just plain wrong to begin with (preemption issues come to mind for one), but went with the quick fix. I'm all ears on the proper fix...
--
Regards,
George
Quoted 58 lines
Regards,
Tony
Quoted 53 lines
Signed-off-by George G. Davis <[email protected]>Acked-by Jarkko Nikula <[email protected]>--- arch/arm/mach-omap2/control.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)arch/arm/mach-omap2/control.c +6
-0@@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset) {return __raw_readb (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readb);u16 omap_ctrl_readw (u16 offset) {return __raw_readw (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readw);u32 omap_ctrl_readl (u16 offset) {return __raw_readl (OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_readl);void omap_ctrl_writeb (u8 val,u16 offset) {__raw_writeb (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writeb);void omap_ctrl_writew (u16 val,u16 offset) {__raw_writew (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writew);void omap_ctrl_writel (u32 val,u16 offset) {__raw_writel (val,OMAP_CTRL_REGADDR (offset)); } +EXPORT_SYMBOL (omap_ctrl_writel);Signature · 6 lines
1.6.1.2.MVISTA -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html