lm90: Support the MAX6648/6692 chips
Subsystems (3)
PATCH 1/1 lm90: Support the MAX6648/6692 chips
The max6648 chip has nearly the same register set as the 6657 and seems to have a working manufacturer/chip id so we can detect it. This patch adds support for it. Tested on a Nvidia Quadro FX 1500 card.
---
drivers/hwmon/Kconfig | 4 ++-- drivers/hwmon/lm90.c | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-)
drivers/hwmon/Kconfig +2 -2
@@ -550,8 +550,8 @@ config SENSORS_LM90 help If you say yes here you get support for National Semiconductor LM90, LM86, LM89 and LM99, Analog Devices ADM1032 and ADT7461, and Maxim - MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680 and - MAX6681 sensor chips. + MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680, + MAX6648, MAX6692 and MAX6681 sensor chips. This driver can also be built as a module. If so, the module will be called lm90.
drivers/hwmon/lm90.c +6 -1
@@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind, && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - } + }else +/* The MAX6648/6692 chips have a working man/chip id +* and the same register set as the 6657. +*/ +if (chip_id =0x59 && address =0x4C ) + kind = max6657; }if (kind <=0 ) {/* identification failed */
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Review static int lm90_detect(struct i2c_client *new_client, int kind, · line 785
Quoted 12 lines · On Mon, 2 Mar 2009 13:01:06 -0800 "Darrick J. Wong" <[email protected]> wrote:
(quoted diff) +6
-1@@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind, && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - } + } else + /* The MAX6648/6692 chips have a working man/chip id + * and the same register set as the 6657. + */ + if (chip_id = 0x59 && address = 0x4C) + kind = max6657; }
gack, the indenting and layout there is totally busted.
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +7 -5
@@ -776,12 +776,14 @@ static int lm90_detect(struct i2c_client && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - }else -/* The MAX6648/6692 chips have a working man/chip id -* and the same register set as the 6657. -*/ -if (chip_id =0x59 && address =0x4C ) + }else if (chip_id =0x59 && address =0x4C ) { +/* +* The MAX6648/6692 chips have a working +* man/chip id and the same register set as the +* 6657. +*/ kind = max6657; + } }if (kind <=0 ) {/* identification failed */
_
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
These three patches look like 2.6.29 material to me. If none of them pop up in linux-next I'll plan to merge them a few days from now.
OK?
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Andrew,
Quoted 17 lines · Andrew Morton
Review static int lm90_detect(struct i2c_client *new_client, int kind, · line 785
Quoted 12 lines · On Mon, 2 Mar 2009 13:01:06 -0800 "Darrick J. Wong" <[email protected]> wrote:
(quoted diff) +6
-1@@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind, && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - } + } else + /* The MAX6648/6692 chips have a working man/chip id + * and the same register set as the 6657. + */ + if (chip_id = 0x59 && address = 0x4C) + kind = max6657; }gack, the indenting and layout there is totally busted.
This specific layout is consistently used through the whole function, and checkpatch.pl doesn't complain about it. While unconventional, it has its advantages, in particular it avoids extra indentation that would make some lines too long. At any rate it doesn't make sense to change this last chunk without changing all the rest if this layout is deemed unacceptable.
Quoted 12 lines
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +1
-5@@ -776,12 +776,14 @@ static int lm90_detect(struct i2c_client && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - } else -/* The MAX6648/6692 chips have a working man/chip id -* and the same register set as the 6657. -*/ - if (chip_id = 0x59 && address = 0x4C) + } else if (chip_id = 0x59 && address = 0x4C) {
drivers/hwmon/lm90.c static int lm90_detect(struct i2c_client · line 789
Quoted 10 lines
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +6
-0+/* +* The MAX6648/6692 chips have a working +* man/chip id and the same register set as the +* 6657. +*/ kind = max6657; + } }if (kind <=0 ) {/* identification failed */
I thus nack this change of yours.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 21 lines · On Tue, 3 Mar 2009 08:47:46 +0100 Jean Delvare <[email protected]> wrote:
Hi Andrew,
Quoted 17 lines · Andrew Morton
Review static int lm90_detect(struct i2c_client *new_client, int kind, · line 785
Quoted 12 lines · On Mon, 2 Mar 2009 13:01:06 -0800 "Darrick J. Wong" <[email protected]> wrote:
(quoted diff) +6
-1@@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind, && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - } + } else + /* The MAX6648/6692 chips have a working man/chip id + * and the same register set as the 6657. + */ + if (chip_id = 0x59 && address = 0x4C) + kind = max6657; }gack, the indenting and layout there is totally busted.
Quoted 6 lines
This specific layout is consistently used through the whole function, and checkpatch.pl doesn't complain about it. While unconventional, it has its advantages, in particular it avoids extra indentation that would make some lines too long. At any rate it doesn't make sense to change this last chunk without changing all the rest if this layout is deemed unacceptable.
lol, be serious.
Quoted 21 lines
Quoted 21 lines
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +7
-5@@ -776,12 +776,14 @@ static int lm90_detect(struct i2c_client && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - }else -/* The MAX6648/6692 chips have a working man/chip id -* and the same register set as the 6657. -*/ -if (chip_id =0x59 && address =0x4C ) + }else if (chip_id =0x59 && address =0x4C ) { +/* +* The MAX6648/6692 chips have a working +* man/chip id and the same register set as the +* 6657. +*/ kind = max6657; + } }
Quoted 3 lines
drivers/hwmon/lm90.c static int lm90_detect(struct i2c_client · line 789
Quoted 1 line
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +0
-0if (kind <=0 ) {/* identification failed */ I thus nack this change of yours.
Something like this...
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~drivers-hwmon-lm90c-fix-coding-style +45 -47
@@ -694,22 +694,22 @@ static int lm90_detect(struct i2c_client LM90_REG_R_CONVRATE)) < 0)return -ENODEV ; -if ((address =0x4C || address =0x4D ) - && man_id =0x01 ) {/* National Semiconductor */ +if ((address =0x4C || address =0x4D ) && man_id =0x01 ) { +/* National Semiconductor */ int reg_config2;if ((reg_config2 =i2c_smbus_read_byte_data (new_client,LM90_REG_R_CONFIG2 )) <0 )return -ENODEV ; -if ((reg_config1 &0x2A ) =0x00 - && (reg_config2 &0xF8 ) =0x00 - && reg_convrate <=0x09 ) { -if (address =0x4C - && (chip_id &0xF0 ) =0x20 ) {/* LM90 */ +if ((reg_config1 &0x2A ) =0x00 && + (reg_config2 &0xF8 ) =0x00 && + reg_convrate <=0x09 ) { +if (address =0x4C && + (chip_id &0xF0 ) =0x20 ) {/* LM90 */ kind = lm90; - }else -if ((chip_id &0xF0 ) =0x30 ) {/* LM89/LM99 */ + }else if ((chip_id &0xF0 ) =0x30 ) { +/* LM89/LM99 */ kind = lm99;dev_info (&adapter->dev, "Assuming LM99 chip at "
@@ -720,27 +720,24 @@ static int lm90_detect(struct i2c_client"loading the lm90 driver\n" ,i2c_adapter_id (adapter), address); - }else -if (address =0x4C - && (chip_id &0xF0 ) =0x10 ) {/* LM86 */ + }else if (address =0x4C && + (chip_id &0xF0 ) =0x10 ) {/* LM86 */ kind = lm86; } } - }else -if ((address =0x4C || address =0x4D ) - && man_id =0x41 ) {/* Analog Devices */ -if ((chip_id &0xF0 ) =0x40 /* ADM1032 */ - && (reg_config1 &0x3F ) =0x00 - && reg_convrate <=0x0A ) { + }else if ((address =0x4C || address =0x4D ) && + man_id =0x41 ) { +/* Analog Devices */ +if ((chip_id &0xF0 ) =0x40 &&/* ADM1032 */ + (reg_config1 &0x3F ) =0x00 && + reg_convrate <=0x0A ) { kind = adm1032; - }else -if (chip_id =0x51 /* ADT7461 */ - && (reg_config1 &0x1B ) =0x00 - && reg_convrate <=0x0A ) { + }else if (chip_id =0x51 &&/* ADT7461 */ + (reg_config1 &0x1B ) =0x00 && + reg_convrate <=0x0A ) { kind = adt7461; } - }else -if (man_id =0x4D ) {/* Maxim */ + }else if (man_id =0x4D ) {/* Maxim */ /* * The MAX6657, MAX6658 and MAX6659 do NOT have a * chip_id register. Reading from that address will
@@ -750,31 +747,32 @@ static int lm90_detect(struct i2c_client* will be those of the previous read, so in our case * those of the man_id register. */ -if (chip_id = man_id - && (address =0x4C || address =0x4D ) - && (reg_config1 &0x1F ) = (man_id &0x0F ) - && reg_convrate <=0x09 ) { +if (chip_id = man_id && + (address =0x4C || address =0x4D ) && + (reg_config1 &0x1F ) = (man_id &0x0F ) && + reg_convrate <=0x09 ) { kind = max6657; - }else -/* The chip_id register of the MAX6680 and MAX6681 -* holds the revision of the chip. -* the lowest bit of the config1 register is unused -* and should return zero when read, so should the -* second to last bit of config1 (software reset) -*/ -if (chip_id =0x01 - && (reg_config1 &0x03 ) =0x00 - && reg_convrate <=0x07 ) { + }else if (chip_id =0x01 && + (reg_config1 &0x03 ) =0x00 && + reg_convrate <=0x07 ) { +/* +* The chip_id register of the MAX6680 and +* MAX6681 holds the revision of the chip. +* the lowest bit of the config1 register is +* unused and should return zero when read, so +* should the second to last bit of config1 +* (software reset) +*/ kind = max6680; - }else -/* The chip_id register of the MAX6646/6647/6649 -* holds the revision of the chip. -* The lowest 6 bits of the config1 register are -* unused and should return zero when read. -*/ -if (chip_id =0x59 - && (reg_config1 &0x3f ) =0x00 - && reg_convrate <=0x07 ) { + }else if (chip_id =0x59 && + (reg_config1 &0x3f ) =0x00 && + reg_convrate <=0x07 ) { +/* +* The chip_id register of the MAX6646/6647/6649 +* holds the revision of the chip. +* The lowest 6 bits of the config1 register are +* unused and should return zero when read. +*/ kind = max6646; }else if (chip_id =0x59 && address =0x4C ) {/*
_
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 180 lines · Andrew Morton
Quoted 21 lines · On Tue, 3 Mar 2009 08:47:46 +0100 Jean Delvare <[email protected]> wrote:
Hi Andrew,
Quoted 17 lines · Andrew Morton
Review static int lm90_detect(struct i2c_client *new_client, int kind, · line 785
Quoted 12 lines · On Mon, 2 Mar 2009 13:01:06 -0800 "Darrick J. Wong" <[email protected]> wrote:
(quoted diff) +6
-1@@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind, && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - } + } else + /* The MAX6648/6692 chips have a working man/chip id + * and the same register set as the 6657. + */ + if (chip_id = 0x59 && address = 0x4C) + kind = max6657; }gack, the indenting and layout there is totally busted.
Quoted 6 lines
This specific layout is consistently used through the whole function, and checkpatch.pl doesn't complain about it. While unconventional, it has its advantages, in particular it avoids extra indentation that would make some lines too long. At any rate it doesn't make sense to change this last chunk without changing all the rest if this layout is deemed unacceptable.
lol, be serious.
Quoted 21 lines
Quoted 21 lines
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +7
-5@@ -776,12 +776,14 @@ static int lm90_detect(struct i2c_client && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646; - }else -/* The MAX6648/6692 chips have a working man/chip id -* and the same register set as the 6657. -*/ -if (chip_id =0x59 && address =0x4C ) + }else if (chip_id =0x59 && address =0x4C ) { +/* +* The MAX6648/6692 chips have a working +* man/chip id and the same register set as the +* 6657. +*/ kind = max6657; + } }Quoted 3 lines
drivers/hwmon/lm90.c static int lm90_detect(struct i2c_client · line 789
Quoted 1 line
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix +0
-0if (kind <=0 ) {/* identification failed */ I thus nack this change of yours.
Something like this...
diff -puN
drivers/hwmon/lm90.c~drivers-hwmon-lm90c-fix-coding-styledrivers/hwmon/lm90.cdrivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~drivers-hwmon-lm90c-fix-coding-style +38
-47@@ -694,22 +694,22 @@ static int lm90_detect(struct i2c_client LM90_REG_R_CONVRATE)) < 0)return -ENODEV ; -if ((address =0x4C || address =0x4D ) - && man_id =0x01 ) {/* National Semiconductor */ +if ((address =0x4C || address =0x4D ) && man_id =0x01 ) { +/* National Semiconductor */ int reg_config2;if ((reg_config2 =i2c_smbus_read_byte_data (new_client,LM90_REG_R_CONFIG2 )) <0 )return -ENODEV ; -if ((reg_config1 &0x2A ) =0x00 - && (reg_config2 &0xF8 ) =0x00 - && reg_convrate <=0x09 ) { -if (address =0x4C - && (chip_id &0xF0 ) =0x20 ) {/* LM90 */ +if ((reg_config1 &0x2A ) =0x00 && + (reg_config2 &0xF8 ) =0x00 && + reg_convrate <=0x09 ) { +if (address =0x4C && + (chip_id &0xF0 ) =0x20 ) {/* LM90 */ kind = lm90; - }else -if ((chip_id &0xF0 ) =0x30 ) {/* LM89/LM99 */ + }else if ((chip_id &0xF0 ) =0x30 ) { +/* LM89/LM99 */ kind = lm99;dev_info (&adapter->dev, "Assuming LM99 chip at "@@ -720,27 +720,24 @@ static int lm90_detect(struct i2c_client"loading the lm90 driver\n" ,i2c_adapter_id (adapter), address); - }else -if (address =0x4C - && (chip_id &0xF0 ) =0x10 ) {/* LM86 */ + }else if (address =0x4C && + (chip_id &0xF0 ) =0x10 ) {/* LM86 */ kind = lm86; } } - }else -if ((address =0x4C || address =0x4D ) - && man_id =0x41 ) {/* Analog Devices */ -if ((chip_id &0xF0 ) =0x40 /* ADM1032 */ - && (reg_config1 &0x3F ) =0x00 - && reg_convrate <=0x0A ) { + }else if ((address =0x4C || address =0x4D ) && + man_id =0x41 ) { +/* Analog Devices */ +if ((chip_id &0xF0 ) =0x40 &&/* ADM1032 */ + (reg_config1 &0x3F ) =0x00 && + reg_convrate <=0x0A ) { kind = adm1032; - }else -if (chip_id =0x51 /* ADT7461 */ - && (reg_config1 &0x1B ) =0x00 - && reg_convrate <=0x0A ) { + }else if (chip_id =0x51 &&/* ADT7461 */ + (reg_config1 &0x1B ) =0x00 && + reg_convrate <=0x0A ) { kind = adt7461; } - }else -if (man_id =0x4D ) {/* Maxim */ + }else if (man_id =0x4D ) {/* Maxim */ /* * The MAX6657, MAX6658 and MAX6659 do NOT have a * chip_id register. Reading from that address will @@ -750,31 +747,32 @@ static int lm90_detect(struct i2c_client* will be those of the previous read, so in our case * those of the man_id register. */ -if (chip_id = man_id - && (address =0x4C || address =0x4D ) - && (reg_config1 &0x1F ) = (man_id &0x0F ) - && reg_convrate <=0x09 ) { +if (chip_id = man_id && + (address =0x4C || address =0x4D ) && + (reg_config1 &0x1F ) = (man_id &0x0F ) && + reg_convrate <=0x09 ) { kind = max6657; - }else -/* The chip_id register of the MAX6680 and MAX6681 -* holds the revision of the chip. -* the lowest bit of the config1 register is unused -* and should return zero when read, so should the -* second to last bit of config1 (software reset) -*/ -if (chip_id =0x01 - && (reg_config1 &0x03 ) =0x00 - && reg_convrate <=0x07 ) { + }else if (chip_id =0x01 && + (reg_config1 &0x03 ) =0x00 && + reg_convrate <=0x07 ) { +/* +* The chip_id register of the MAX6680 and +* MAX6681 holds the revision of the chip. +* the lowest bit of the config1 register is +* unused and should return zero when read, so +* should the second to last bit of config1 +* (software reset) +*/ kind = max6680; - }else -/* The chip_id register of the MAX6646/6647/6649 -* holds the revision of the chip. -* The lowest 6 bits of the config1 register are -* unused and should return zero when read. -*/ -if (chip_id =0x59 - && (reg_config1 &0x3f ) =0x00 - && reg_convrate <=0x07 ) { + }else if (chip_id =0x59 && + (reg_config1 & 0x3f) = 0x00 &&
drivers/hwmon/lm90.c static int lm90_detect(struct i2c_client · line 778
Quoted 10 lines
drivers/hwmon/lm90.c renamed from drivers/hwmon/lm90.c~drivers-hwmon-lm90c-fix-coding-style +7
-0+ reg_convrate <= 0x07) { +/* +* The chip_id register of the MAX6646/6647/6649 +* holds the revision of the chip. +* The lowest 6 bits of the config1 register are +* unused and should return zero when read. +*/ kind = max6646; } else if (chip_id = 0x59 && address = 0x4C) {/*
Yes, something like this. But you know, the lm90 driver has a dedicated maintainer, so you don't need to take care about this driver personally.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Andrew,
Quoted 2 lines · Andrew Morton
These three patches look like 2.6.29 material to me. If none of them pop up in linux-next I'll plan to merge them a few days from now.
As the lm90 driver maintainer, I will take care of the lm90 patch. Feel free to handle the lm85 patches if you want.
Thanks,
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Darrick
Quoted 35 lines · Darrick J. Wong
The max6648 chip has nearly the same register set as the 6657 and seems to have a working manufacturer/chip id so we can detect it. This patch adds support for it. Tested on a Nvidia Quadro FX 1500 card.
Signed-off-by Darrick J. Wong <[email protected]>---
drivers/hwmon/Kconfig | 4 ++-- drivers/hwmon/lm90.c | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-)drivers/hwmon/Kconfig +2
-2@@ -550,8 +550,8 @@ config SENSORS_LM90 help If you say yes here you get support for National Semiconductor LM90, LM86, LM89 and LM99, Analog Devices ADM1032 and ADT7461, and Maxim - MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680 and - MAX6681 sensor chips. + MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680, + MAX6648, MAX6692 and MAX6681 sensor chips. This driver can also be built as a module. If so, the module will be called lm90.drivers/hwmon/lm90.c +0
-0@@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind, && (reg_config1 & 0x3f) = 0x00 && reg_convrate <= 0x07) { kind = max6646;
drivers/hwmon/lm90.c static int lm90_detect(struct i2c_client *new_client, int kind, · line 787
Quoted 10 lines
drivers/hwmon/lm90.c +6
-1- } + }else +/* The MAX6648/6692 chips have a working man/chip id +* and the same register set as the 6657. +*/ +if (chip_id =0x59 && address =0x4C ) + kind = max6657; }if (kind <=0 ) {/* identification failed */
I am confused. According to my notes, the MAX6648/MAX6692 is the same chip as the MAX6646/MAX6647/MAX6649 (same chip ID of 0x59), the only difference being the I2C address (0x4c for the MAX6646, 0x4e for the MAX6647 and 0x4d for the MAX6648/MAX6649/MAX6692). So the current code should _already_ detect your MAX6648 or MAX6692 as kind = max6646.
Can you please test the latest version of the sensors-detect script [1] and let me know if your chip is properly detected? If not, please provide a dump of your chip.
[1] http://www.lm-sensors.org/svn/lm-sensors/trunk/prog/detect/sensors-detect
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 6 lines · Jean Delvare
Hi Darrick
I am confused. According to my notes, the MAX6648/MAX6692 is the same chip as the MAX6646/MAX6647/MAX6649 (same chip ID of0x59), the only difference being the I2C address (0x4cfor the MAX6646,0x4efor the MAX6647 and0x4dfor the MAX6648/MAX6649/MAX6692). So the current code should _already_ detect your MAX6648 or MAX6692 as kind = max6646.
Heh, yep, it does. I guess this patch has been sitting around long enough to become obsolete, sorry for the unnecessary mail traffic. I guess we can drop this one.
Quoted 3 lines
Can you please test the latest version of the sensors-detect script [1] and let me know if your chip is properly detected? If not, please provide a dump of your chip.
Just for fun, here's a dump of that chip (6648):
No size specified (using byte-data access)
0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef 00: 15 1d 00 00 05 69 00 6e 05 05 05 05 05 05 05 05 ??..?i.n???????? 10: e0 c0 c0 c0 c0 c0 c0 c0 00 91 91 91 91 91 91 91 ????????.??????? 20: 91 0a 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 30: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 40: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 50: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 60: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 70: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 80: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 90: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? a0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? b0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? c0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? d0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? e0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? f0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 4d 59 ??????????????MY
This also detects it properly.
--D
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Darrick,
Quoted 10 lines · Darrick J. Wong
Quoted 5 lines · Jean Delvare
I am confused. According to my notes, the MAX6648/MAX6692 is the same chip as the MAX6646/MAX6647/MAX6649 (same chip ID of
0x59), the only difference being the I2C address (0x4cfor the MAX6646,0x4efor the MAX6647 and0x4dfor the MAX6648/MAX6649/MAX6692). So the current code should _already_ detect your MAX6648 or MAX6692 as kind = max6646.Heh, yep, it does. I guess this patch has been sitting around long enough to become obsolete, sorry for the unnecessary mail traffic. I guess we can drop this one.
Well, confusion probably would have been avoided if it had been properly documented that the MAX6648 and MAX6692 were already supported. So I think we should still apply the Kconfig part of your patch. Documentation/hwmon/lm90 would need a small update as well. Could you please send an updated patch doing this? I would be happy to apply that.
Thanks,
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
PATCH 1/1 lm90: Document support for the MAX6648/6692 chips
Update documentation to prevent further confusion/duplication.
---
drivers/hwmon/Kconfig | 4 ++-- drivers/hwmon/lm90.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/hwmon/Kconfig +2 -2
@@ -550,8 +550,8 @@ config SENSORS_LM90 help If you say yes here you get support for National Semiconductor LM90, LM86, LM89 and LM99, Analog Devices ADM1032 and ADT7461, and Maxim - MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680 and - MAX6681 sensor chips. + MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680, + MAX6648, MAX6692 and MAX6681 sensor chips. This driver can also be built as a module. If so, the module will be called lm90.
drivers/hwmon/lm90.c +4 -4
@@ -32,10 +32,10 @@* supported by this driver. These chips lack the remote temperature * offset feature. * -* This driver also supports the MAX6646, MAX6647 and MAX6649 chips -* made by Maxim. These are again similar to the LM86, but they use -* unsigned temperature values and can report temperatures from 0 to -* 145 degrees. +* This driver also supports the MAX6646, MAX6647, MAX6648, MAX6649, and +* MAX6692 chips made by Maxim. These are again similar to the LM86, +* but they use unsigned temperature values and can report temperatures +* from 0 to 145 degrees. * * This driver also supports the MAX6680 and MAX6681, two other sensor * chips made by Maxim. These are quite similar to the other Maxim
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
PATCH 1/1 lm90: Update Documentation/hwmon/lm90 to reflect max6648/92 support
In reply to Jean DelvareOops, forgot this piece.
---
Update Documentation/hwmon/lm90 to add max6648/92 support.
---
Documentation/hwmon/lm90 | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
Documentation/hwmon/lm90 +5 -0
@@ -42,6 +42,11 @@ Supported chips: Addresses scanned: I2C 0x4e Datasheet: Publicly available at the Maxim website http://www.maxim-ic.com/quick_view2.cfm/qv_pk/3497 + * Maxim MAX6648/MAX6692 + Prefix: 'max6646' + Addresses scanned: I2C 0x4c + Datasheet: Publicly available at the Maxim website + http://www.maxim-ic.com/getds.cfm/qv_pk/3500 * Maxim MAX6649 Prefix: 'max6646' Addresses scanned: I2C 0x4c
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Jean Delvare
AppliedRe: [PATCH] lm90: Document support for the MAX6648/6692 chips
In reply to Darrick J. WongQuoted 33 lines · Darrick J. Wong
Update documentation to prevent further confusion/duplication.
Signed-off-by Darrick J. Wong <[email protected]>---
drivers/hwmon/Kconfig | 4 ++-- drivers/hwmon/lm90.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)drivers/hwmon/Kconfig +2
-2@@ -550,8 +550,8 @@ config SENSORS_LM90 help If you say yes here you get support for National Semiconductor LM90, LM86, LM89 and LM99, Analog Devices ADM1032 and ADT7461, and Maxim - MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680 and - MAX6681 sensor chips. + MAX6646, MAX6647, MAX6649, MAX6657, MAX6658, MAX6659, MAX6680, + MAX6648, MAX6692 and MAX6681 sensor chips. This driver can also be built as a module. If so, the module will be called lm90.drivers/hwmon/lm90.c +0
-1@@ -32,10 +32,10 @@* supported by this driver. These chips lack the remote temperature * offset feature. * -* This driver also supports the MAX6646, MAX6647 and MAX6649 chips
drivers/hwmon/lm90.c line 41
Quoted 10 lines
drivers/hwmon/lm90.c +4
-3-* made by Maxim. These are again similar to the LM86, but they use -* unsigned temperature values and can report temperatures from 0 to -* 145 degrees. +* This driver also supports the MAX6646, MAX6647, MAX6648, MAX6649, and +* MAX6692 chips made by Maxim. These are again similar to the LM86, +* but they use unsigned temperature values and can report temperatures +* from 0 to 145 degrees. * * This driver also supports the MAX6680 and MAX6681, two other sensor * chips made by Maxim. These are quite similar to the other Maxim
Applied, thanks!
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors