Seperate mtdpart command from jffs2
PATCH 1/1 Seperate mtdpart command from jffs2
Some program such as UBI only used the mtdpart only.
however current jffs2 cmdline has dependent with jffs2 cmd This patch make a build only jffs2 cmdline without jffs2 cmd dependency.
---
common/Makefile +1 -0
@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o +COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.o COBJS-$(CONFIG_CMD_LICENSE) += cmd_license.o COBJS-y += cmd_load.o COBJS-$(CONFIG_LOGBUFFER) += cmd_log.o
common/cmd_jffs2.c +3 -1722
1,771 lines not on this page · raw message
common/cmd_mtdparts.c new file +1986 -0
1,222 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Part of the diff is not shown here. View the raw message.
PATCH 1/1 Seperate mtdpart command from jffs2
Quoted 3 lines · Kyungmin Park
Some program such as UBI only used the mtdpart only.
however current jffs2 cmdline has dependent with jffs2 cmd This patch make a build only jffs2 cmdline without jffs2 cmd dependency.
Thanks. I'll review it in a few days.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 Seperate mtdpart command from jffs2
In reply to Kyungmin ParkHi Kyungmin,
Quoted 3 lines · Kyungmin Park
Some program such as UBI only used the mtdpart only.
however current jffs2 cmdline has dependent with jffs2 cmd This patch make a build only jffs2 cmdline without jffs2 cmd dependency.
I tried to rephrase this description a little bit:
"
Currently the mtdparts commands are included in the jffs2 command support. This doesn't make sense anymore since other commands (e.g. UBI) use this infrastructure as well now. This patch separates the mtdparts commands from the jffs2 commands making it possible to only select mtdparts when no JFFS2 support is needed.
"
If you don't have any objections I suggest to use this description in your next patch version.
Please find some more comments below.
common/Makefile COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o · line 101
Quoted 11 lines
Signed-off-by Kyungmin Park <[email protected]>---
common/Makefile +1
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o +COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.o
Shouldn't we change this define (CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it to CONFIG_CMD_MTDPARTS. This seems more logical to me.
What do you think?
This patch also breaks (at least some) boards with JFFS2 support:
[stefan at kubuntu u-boot (master)]$ ./MAKEALL fx12mm
Configuring for fx12mm board...
cmd_jffs2.c:164: warning: 'device_validate' defined but not used cmd_jffs2.c:220: warning: 'id_parse' defined but not used common/libcommon.a(cmd_flash.o): In function `do_protect':/home/stefan/git/u-boot/u-boot/common/cmd_flash.c:568: undefined reference to `id_parse'
common/libcommon.a(cmd_flash.o): In function `do_flerase':/home/stefan/git/u-boot/u-boot/common/cmd_flash.c:362: undefined reference to `id_parse'
make: *** [u-boot] Error 1
ppc_4xx-size: './u-boot': No such file
I didn't try to solve this problem (yet). Perhaps you have an idea?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 Seperate mtdpart command from jffs2
Dear Stefan Roese,
Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 5 lines
COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.What do you think?
I agree - CONFIG_CMD_MTDPARTS is much better - CONFIG_CMD_MTDPARTS is much better. Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Spock, did you see the looks on their faces?" "Yes, Captain, a sort of vacant contentment."
PATCH 1/1 Seperate mtdpart command from jffs2
In reply to Stefan RoeseQuoted 38 lines · Stefan Roese
Hi Kyungmin,
Quoted 3 lines · Kyungmin Park
Some program such as UBI only used the mtdpart only.
however current jffs2 cmdline has dependent with jffs2 cmd This patch make a build only jffs2 cmdline without jffs2 cmd dependency.I tried to rephrase this description a little bit:
"
Currently the mtdparts commands are included in the jffs2 command support. This doesn't make sense anymore since other commands (e.g. UBI) use this infrastructure as well now. This patch separates the mtdparts commands from the jffs2 commands making it possible to only select mtdparts when no JFFS2 support is needed.
"If you don't have any objections I suggest to use this description in your next patch version.
Please find some more comments below.
Quoted 11 lines
Signed-off-by Kyungmin Park <[email protected]>---
common/Makefile +0
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.
Quoted 1 line
What do you think?
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Quoted 17 lines
This patch also breaks (at least some) boards with JFFS2 support:
[stefan at kubuntu u-boot (master)]$ ./MAKEALL fx12mm
Configuring for fx12mm board...
cmd_jffs2.c:164: warning: 'device_validate' defined but not used cmd_jffs2.c:220: warning: 'id_parse' defined but not used common/libcommon.a(cmd_flash.o): In function `do_protect':/home/stefan/git/u-boot/u-boot/common/cmd_flash.c:568: undefined reference to `id_parse'
common/libcommon.a(cmd_flash.o): In function `do_flerase':/home/stefan/git/u-boot/u-boot/common/cmd_flash.c:362: undefined reference to `id_parse'
make: *** [u-boot] Error 1
ppc_4xx-size: './u-boot': No such file
Quoted 1 line
I didn't try to solve this problem (yet). Perhaps you have an idea?
In both case jffs2 and mtdpart, have id_parse as changed to static, so one of both should be non-static. I think remove static at cmd_jffs2.c
Thank you,
Kyungmin Park
PATCH 1/1 Seperate mtdpart command from jffs2
Quoted 11 lines · Kyungmin Park
Quoted 11 lines
Quoted 6 lines
+++ b/common/Makefile
(quoted diff) +0
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.
Quoted 3 lines
Quoted 1 line
What do you think?
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
Quoted 16 lines
Quoted 16 lines
This patch also breaks (at least some) boards with JFFS2 support:
[stefan at kubuntu u-boot (master)]$ ./MAKEALL fx12mm Configuring for fx12mm board...
cmd_jffs2.c:164: warning: 'device_validate' defined but not used cmd_jffs2.c:220: warning: 'id_parse' defined but not used common/libcommon.a(cmd_flash.o): In function `do_protect':/home/stefan/git/u-boot/u-boot/common/cmd_flash.c:568: undefined reference toid_parse' common/libcommon.a(cmd_flash.o): In functiondo_flerase':/home/stefan/git/u-boot/u-boot/common/cmd_flash.c:362: undefined reference to `id_parse'
make: *** [u-boot] Error 1
ppc_4xx-size: './u-boot': No such file
Quoted 4 lines
Quoted 1 line
I didn't try to solve this problem (yet). Perhaps you have an idea?
In both case jffs2 and mtdpart, have
id_parseas changed to static, so one of both should be non-static. I think remove static atcmd_jffs2.c
It would be great if you could fix this issue in your next patch version.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 Seperate mtdpart command from jffs2
Quoted 12 lines · Stefan Roese
Quoted 11 lines · Kyungmin Park
Quoted 11 lines
Quoted 6 lines
+++ b/common/Makefile
(quoted diff) +0
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
What do you think?
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a84d97f287b2ca15486a1
Best Regards,
J.
PATCH 1/1 Seperate mtdpart command from jffs2
Hi Jean-Christophe,
Quoted 15 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 14 lines · Stefan Roese
Quoted 13 lines · Kyungmin Park
Quoted 12 lines
Quoted 6 lines
+++ b/common/Makefile
(quoted diff) +0
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.What do you think?
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a
84d97f287b2ca15486a1
Hmm. Now I'm a little confused. It seems that you added this patch with some changes to the "for-next" branch of your arm git repository. Did you post the changed version of this patch on the list? I couldn't find it.
Don't get me wrong. I appreciate that you did the required change to the patch. But please post the path on the list after you changed it. And also please incorporate the change to the patch description as I suggested. Additionally I think that this patch doesn't really belong into your arm repository.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 Seperate mtdpart command from jffs2
Quoted 26 lines · Stefan Roese
Hi Jean-Christophe,
Quoted 15 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 14 lines · Stefan Roese
Quoted 13 lines · Kyungmin Park
Quoted 12 lines
Quoted 6 lines
+++ b/common/Makefile
(quoted diff) +0
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.What do you think?
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a
84d97f287b2ca15486a1
Quoted 6 lines
Hmm. Now I'm a little confused. It seems that you added this patch with some changes to the "for-next" branch of your arm git repository. Did you post the changed version of this patch on the list? I couldn't find it.
Don't get me wrong. I appreciate that you did the required change to the patch. But please post the path on the list after you changed it.
yes but was too big and automaticly-reject
Quoted 2 lines
And also
please incorporate the change to the patch description as I suggested.
which?
Quoted 2 lines
Additionally I think that this patch doesn't really belong into your arm repository.
I've put here due to the ML limit that's all
Best Regards,
J.
PATCH 1/1 Seperate mtdpart command from jffs2
Quoted 8 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841
089a84d97f287b2ca15486a1
Quoted 8 lines
Quoted 6 lines
Hmm. Now I'm a little confused. It seems that you added this patch with some changes to the "for-next" branch of your arm git repository. Did you post the changed version of this patch on the list? I couldn't find it.
Don't get me wrong. I appreciate that you did the required change to the patch. But please post the path on the list after you changed it.
yes but was too big and automaticly-reject
Ahh, I see. :-(
Quoted 4 lines
Quoted 2 lines
And also
please incorporate the change to the patch description as I suggested.which?
In my first review.
Quoted 4 lines
Quoted 2 lines
Additionally I think that this patch doesn't really belong into your arm repository.
I've put here due to the ML limit that's all
I'm hoping that Wolfgang will sent this patch to the list a a little while.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 Seperate mtdpart command from jffs2
In reply to Jean-Christophe PLAGNIOL-VILLARDDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 7 lines
Hmm. Now I'm a little confused. It seems that you added this patch with some changes to the "for-next" branch of your arm git repository. Did you post the changed version of this patch on the list? I couldn't find it.
Quoted 1 line
Don't get me wrong. I appreciate that you did the required change to the > patch. But please post the path on the list after you changed it.
yes but was too big and automaticly-reject
Patches don't get automatically rejected. It is me who rejects them, and I add an explanation when I do. Please re-read the reject message and follow the advise.
Quoted 3 lines
Quoted 2 lines
Additionally I think that this patch doesn't really belong into your arm repository.
I've put here due to the ML limit that's all
But this is awfully wrong.
You are not supposed to put random patches into your repository. This is supposed to be an ARM custian repo, and nothing else.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If only God would give me some clear sign! Like making a large depo- sit in my name at a Swiss Bank. - Woody Allen
PATCH 1/1 Seperate mtdpart command from jffs2
In reply to Stefan RoeseDear Stefan Roese,
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 2 lines
I've put here due to the ML limit that's all
I'm hoping that Wolfgang will sent this patch to the list a a little while.
I don't have any pending patches in moderation.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Misquotation is, in fact, the pride and privilege of the learned. A
widely-read man never quotes accurately, for the rather obvious
reason that he has read too widely.
- Hesketh Pearson _Common Misquotations_ introductionPATCH 1/1 Seperate mtdpart command from jffs2
In reply to Jean-Christophe PLAGNIOL-VILLARDQuoted 13 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 12 lines · Stefan Roese
Quoted 11 lines · Kyungmin Park
Quoted 11 lines
Quoted 6 lines
+++ b/common/Makefile
(quoted diff) +0
-0@@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
+COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.oShouldn't we change this define (
CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it toCONFIG_CMD_MTDPARTS. This seems more logical to me.
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
What do you think?
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a84d97f287b2ca15486a1
please refer to this one instead
http://game.jcrosoft.org/git?p=u-boot-arm.git;a=commit;h=9163868e5575d841089a84d97f287b2ca15486a1
Best Regards,
J.
PATCH 1/1 Seperate mtdpart command from jffs2
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 3 lines
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a84d97f287b2ca15486a1
please refer to this one instead
http://game.jcrosoft.org/git?p=u-boot-arm.git;a=commit;h=9163868e5575d841089a84d97f287b2ca15486a1
I already explained to you that the documentation (cf.
http://www.denx.de/wiki/U-Boot/Patches) requires "a URL (link) pointing to your patch", and that a web interface to some git repository is NOT a patch.
Also note (again) that there were specific reasons why I rejected your patch, and re-posting the same thing again unchanged will not make me accept it.
You must at least make clear what the differences between your version and Kyungmin Park's original patch are, and why we should use your's and not his.
And you must fix the commit message which makes no sense to me.
Please fix all this before reposting, and then please follow the documented rules.
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"He only drinks when he gets depressed." "Why does he get depressed?"
"Sometimes it's because he hasn't had a drink."
- Terry Pratchett, _Men at Arms_