Skip to contentSkip to conversation

x86: oqo: depends on INPUT_POLLDEV

PATCH Applied [email protected] 5 participants 10 messages Mar 4, 2009 – May 30, 2009

Subsystems (2)
ACPI x86 platform drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/8 x86: oqo: depends on INPUT_POLLDEV

From: Randy Dunlap <[email protected]>

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig renamed from drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +1 -1
diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
        help

_

reviewer Applied
#1 lore raw

applied to oqo-wmi-EXPECT-REFRESH branch

expecting a revised patch from Matthew at some point...

thanks
--
Len Brown, Intel Open Source Technology Center

Quoted 36 lines · On Wed, 4 Mar 2009, [email protected] wrote:

From: Randy Dunlap <[email protected]>

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig

drivers/platform/x86/Kconfig renamed from drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +1 -1
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
        help

_

#2 lore raw
In reply to [email protected]
Quoted 29 lines · On Wednesday 04 March 2009 11:55:24 [email protected] wrote:

From: Randy Dunlap <[email protected]>

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR:
"input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig --- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ a/drivers/platform/x86/Kconfig

drivers/platform/x86/Kconfig config MSI_LAPTOP · line 140

Quoted 5 lines
drivers/platform/x86/Kconfig renamed from drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +1 -1
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV

Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users should not have to select it for some drivers to become available.

Signature · 1 line
Dmitry
#3 lore raw
Quoted 25 lines · Dmitry Torokhov
Quoted 24 lines · On Wednesday 04 March 2009 11:55:24 [email protected] wrote:

From: Randy Dunlap <[email protected]>

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR:
"input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

drivers/platform/x86/Kconfig config MSI_LAPTOP · line 140

Quoted 10 lines

diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig --- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ a/drivers/platform/x86/Kconfig

drivers/platform/x86/Kconfig renamed from drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +1 -1
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV

Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users should not have to select it for some drivers to become available.

Did the OQO_WMI stuff go away? I can't seem to find it anywhere.

Signature · 1 line
~Randy
reviewer
#4 lore raw
Quoted 19 lines
Quoted 4 lines
Quoted 4 lines
 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

drivers/platform/x86/Kconfig config MSI_LAPTOP · line 140

Quoted 10 lines

diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig --- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ a/drivers/platform/x86/Kconfig

drivers/platform/x86/Kconfig renamed from drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +1 -1
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV

Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users should not have to select it for some drivers to become available.

Quoted 1 line

Did the OQO_WMI stuff go away? I can't seem to find it anywhere.

yeah, i droppped it from my test tree while distracted with the 2.6.30 merge. it is back now.

-Len Brown, Intel Open Source Technology Center

#5 lore raw

x86 platform: oqo: select INPUT_POLLDEV

From: Randy Dunlap <[email protected]>

OQO_WMI uses INPUT_POLLDEV, but it can select that instead of depending on it, since it represents library code.

Signed-off-by Randy Dunlap <[email protected]>
Cc Dmitry Torokhov <[email protected]>
Cc Len Brown <[email protected]>
---
 drivers/platform/x86/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/platform/x86/Kconfig +2 -1
@@ -146,9 +146,10 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT && INPUT_POLLDEV
+       depends on INPUT
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
+	select INPUT_POLLDEV
        help
          Say Y here if you want to support rfkill and backlight control on
          series 2 OQO handheld devices.
Signature · 3 lines
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
reviewer
#7 lore raw

Re: x86 platform: oqo: select INPUT_POLLDEV

applied to oqo-wmi-EXPECT-REFRESH branch in acpi test tree.

mjg -- shall I send you the stuff collected on that branch branch so that you can refresh it for 2.6.31?

thanks,
Len Brown, Intel Open Source Technology Center

#8 lore raw

Re: x86 platform: oqo: select INPUT_POLLDEV

Quoted 4 lines · Len Brown

applied to oqo-wmi-EXPECT-REFRESH branch in acpi test tree.

mjg -- shall I send you the stuff collected on that branch branch so that you can refresh it for 2.6.31?

Is it public? I can pull it myself easily enough.

Signature · 1 line
Matthew Garrett | [email protected]
reviewer Acked-by Dmitry Torokhov Acked-by Matthew Garrett
#9 lore raw

Re: x86 platform: oqo: select INPUT_POLLDEV

Quoted 2 lines

Is it public? I can pull it myself easily enough.

yes, commit id's below.

thanks,
Len Brown, Intel Open Source Technology Center

commit 261a37014c353eb392334f31f6bc2166253d12c2

Author: Randy Dunlap <[email protected]>
Date:   Tue May 26 23:59:27 2009 -0700

oqo: select INPUT_POLLDEV
From: Randy Dunlap <[email protected]>

OQO_WMI uses INPUT_POLLDEV, but it can select that instead of
depending on
it, since it represents library code.

Signed-off-by Randy Dunlap <[email protected]>
Acked-by Dmitry Torokhov <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Signed-off-by Len Brown <[email protected]>

commit 0eba5e81e02f5f239e3691c9e9f9afef3050b387

Author: Randy Dunlap <[email protected]>
Date:   Wed Mar 4 11:55:24 2009 -0800

x86: oqo: depends on INPUT_POLLDEV

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

ERROR: "input_register_polled_device"
[drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_allocate_polled_device"
[drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko]
undefined!
ERROR: "input_unregister_polled_device"
[drivers/platform/x86/oqo-wmi.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Acked-by Matthew Garrett <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Signed-off-by Len Brown <[email protected]>

commit 94c4b5977f33894cc316edf07c5cb72b5d193628

Author: Len Brown <[email protected]>
Date:   Fri Feb 6 23:06:38 2009 -0500

oqo: dev_set_name()

Signed-off-by Len Brown <[email protected]>

commit 9c82cd255907ad639bed4ffc8fcaf1bd59badb50

Author: Matthew Garrett <[email protected]>
Date:   Wed Dec 3 19:55:37 2008 +0000

platform/x86: Add oqo-wmi driver for model 2 OQO backlight and rfkill
control

oqo-wmi provides a WMI-based interface to backlight and rfkill control
on
model 2 OQO devices. It was originally written by Brian Julin (<[email protected]>) - I've ported it to the rfkill layer and tidied it
up a
little.

Signed-off-by Matthew Garrett <[email protected]>
Signed-off-by Len Brown <[email protected]>