2.6.29-rc5+: usb bluetooth crashes system
Hi!
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 4 lines · Pavel Machek
Hi!
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
Do we have a trace?
Quoted 4 lines · Pavel Machek
Hi!
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
OK, I _guess_ you have switched from 2.6.28.
Thanks,
Rafael
Quoted 7 lines · Greg KH
Quoted 4 lines · Pavel Machek
Hi!
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
Do we have a trace?
We have "bad magic" message, see bugzilla. I guess it is use of spinlock after free?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Marcel Holtmann
maintainerHi Pavel,
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
Do we have a trace?
We have "bad magic" message, see bugzilla. I guess it is use of spinlock after free?
can you double check with the net-next-2.6 or bluetooth-next-2.6 tree and see if that issue is still present.
Regards
Marcel
Quoted 5 lines · Marcel Holtmann
Hi Pavel,
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Do we have a trace?
We have "bad magic" message, see bugzilla. I guess it is use of spinlock after free?
can you double check with the net-next-2.6 or bluetooth-next-2.6 tree and see if that issue is still present.
Well, I took btusb.c from 2.6.28 and that fixed the issue; so we know the regression is in btusb.c file between 28 and 29-rc7. If you have specific version of btusb.c you want me to test, please mail it to me.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Since switch to 2.6.29-rc, bluetooth crashes system... usually on disconnect or killall pppd.
Do we have a trace?
We have "bad magic" message, see bugzilla. I guess it is use of spinlock after free?
Quoted 6 lines
Quoted 2 lines
can you double check with the net-next-2.6 or bluetooth-next-2.6 tree and see if that issue is still present.
Well, I took
btusb.cfrom 2.6.28 and that fixed the issue; so we know the regression is inbtusb.cfile between 28 and 29-rc7. If you have specific version ofbtusb.cyou want me to test, please mail it to me.
This smaller patch (partial revert of btusb.c to 2.6.28 state) seems to help, too....
Pavel
drivers/bluetooth/btusb.c +14 -27
@@ -655,19 +680,8 @@ static void btusb_notify(struct hci_dev *hdev, unsigned int evt)BT_DBG ("%s evt %d" , hdev->name, evt); -if (hdev->conn_hash.acl_num >0 ) { -if (!test_and_set_bit (BTUSB_BULK_RUNNING , &data->flags)) { -if (btusb_submit_bulk_urb (hdev,GFP_ATOMIC ) <0 ) -clear_bit (BTUSB_BULK_RUNNING , &data->flags); -else -btusb_submit_bulk_urb (hdev,GFP_ATOMIC ); - } - }else { -clear_bit (BTUSB_BULK_RUNNING , &data->flags); -usb_unlink_anchored_urbs (&data->bulk_anchor); - } - -schedule_work (&data->work); +if (evt ==HCI_NOTIFY_CONN_ADD || evt ==HCI_NOTIFY_CONN_DEL ) +schedule_work (&data->work); }static int inline __set_isoc_interface (struct hci_dev *hdev,int altsetting)
@@ -718,6 +732,18 @@ static void btusb_work(struct work_struct *work) struct btusb_data *data = container_of(work, struct btusb_data, work);struct hci_dev *hdev = data->hdev; +if (hdev->conn_hash.acl_num >0 ) { +if (!test_and_set_bit (BTUSB_BULK_RUNNING , &data->flags)) { +if (btusb_submit_bulk_urb (hdev) <0 ) +clear_bit (BTUSB_BULK_RUNNING , &data->flags); +else +btusb_submit_bulk_urb (hdev); + } + }else { +clear_bit (BTUSB_BULK_RUNNING , &data->flags); +usb_kill_anchored_urbs (&data->bulk_anchor); + } +if (hdev->conn_hash.sco_num >0 ) {if (data->isoc_altsetting !=2 ) {clear_bit (BTUSB_ISOC_RUNNING , &data->flags);
@@ -852,23 +876,9 @@ static int btusb_probe(struct usb_interface *intf,if (id->driver_info &BTUSB_BROKEN_ISOC ) data->isoc =NULL ; -if (id->driver_info &BTUSB_DIGIANSWER ) { - data->cmdreq_type =USB_TYPE_VENDOR ; -set_bit (HCI_QUIRK_NO_RESET , &hdev->quirks); - } - -if (id->driver_info &BTUSB_CSR ) { -struct usb_device *udev = data->udev; - -/* Old firmware would otherwise execute USB reset */ -if (le16_to_cpu (udev->descriptor.bcdDevice) <0x117 ) -set_bit (HCI_QUIRK_NO_RESET , &hdev->quirks); - } -if (id->driver_info &BTUSB_SNIFFER ) {struct usb_device *udev = data->udev; -/* New sniffer firmware has crippled HCI interface */ if (le16_to_cpu (udev->descriptor.bcdDevice) >0x997 )set_bit (HCI_QUIRK_RAW_DEVICE , &hdev->quirks);
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Am Donnerstag 26 März 2009 10:58:56 schrieb Pavel Machek:
Quoted 6 lines
Quoted 3 lines
Well, I took
btusb.cfrom 2.6.28 and that fixed the issue; so we know the regression is inbtusb.cfile between 28 and 29-rc7. If you have specific version ofbtusb.cyou want me to test, please mail it to me.This smaller patch (partial revert of
btusb.cto 2.6.28 state) seems to help, too....
Could you test whether reversing the changes to btusb_probe() alone helps?
Regards
Oliver
Marcel Holtmann
maintainerHi Oliver,
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Well, I took
btusb.cfrom 2.6.28 and that fixed the issue; so we know the regression is inbtusb.cfile between 28 and 29-rc7. If you have specific version ofbtusb.cyou want me to test, please mail it to me.This smaller patch (partial revert of
btusb.cto 2.6.28 state) seems to help, too....Could you test whether reversing the changes to
btusb_probe()alone helps?
just test net-next-2.6 or latest Linus' tree once he pulled the networking changes from Dave.
We had to partly revert that change for some hardware. Believe it or not, but some Bluetooth chips don't work if we don't submit the bulk URBs along with the interrupt URBs.
Regards
Marcel