Skip to contentSkip to conversation

s3cmci: fix s3c2410_dma_config() arguments.

PATCH Ben Dooks 1 participant 1 message Mar 10, 2009 MMC, SD and SDIO

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

From: Ben Dooks <[email protected]>

The s3cmci driver is calling s3c2410_dma_config with incorrect data for the DCON register. The S3C2410_DCON_HWTRIG is implicit in the channel configuration and the device selection of S3C2410_DCON_CH0_SDI is incorrect as the DMA system may not select channel 0.

drivers/mmc/host/s3cmci.c +1 -2
Index: linux.git/drivers/mmc/host/s3cmci.c
===================================================================
@@ -793,8 +793,7 @@ static void s3cmci_dma_setup(struct s3cm
 			      host->mem->start + host->sdidata);
 
 	if (!setup_ok) {
-		s3c2410_dma_config(host->dma, 4,
-			(S3C2410_DCON_HWTRIG | S3C2410_DCON_CH0_SDI));
+		s3c2410_dma_config(host->dma, 4, 0);
 		s3c2410_dma_set_buffdone_fn(host->dma,
 					    s3cmci_dma_done_callback);
 		s3c2410_dma_setflags(host->dma, S3C2410_DMAF_AUTOSTART);
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'