Skip to contentSkip to conversation

ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu()

PATCH In review Wu Fengguang 2 participants 3 messages Mar 12, 2009 – Mar 16, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu()

This fixes a NULL pointer dereference bug introduced by 6e911954cac.

---

arch/x86/kernel/acpi/cstate.c +1 -1
index 6626e8c..b866b87 100644
@@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
 	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
 
 	retval = smp_call_function_single(cpu,
-				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
+				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
 	if (retval == 0) {
 		retval = cxcc.retval;
 		if (retval == 0) {
reviewer
#1 lore raw
Quoted 1 line · Wu Fengguang

This fixes a NULL pointer dereference bug introduced by 6e911954cac.

What tree is this patch on top of?

thanks,
-Len Brown
Intel Open Source Technology Center

Quoted 20 lines

---

arch/x86/kernel/acpi/cstate.c +1 -2
index 6626e8c..b866b87 100644
@@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
 	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
 
 	retval = smp_call_function_single(cpu,
-				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
+				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
 	if (retval == 0) {
 		retval = cxcc.retval;
 		if (retval == 0) {
--

To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 5 lines · Len Brown
Quoted 1 line · Wu Fengguang

This fixes a NULL pointer dereference bug introduced by 6e911954cac.

What tree is this patch on top of?

It's for 2.6.29-rc7-next-20090311. Already fixed in other trees?

Thanks,
Fengguang

Quoted 24 lines

thanks,
-Len Brown
Intel Open Source Technology Center

Quoted 20 lines

---

arch/x86/kernel/acpi/cstate.c +1 -2
index 6626e8c..b866b87 100644
@@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
 	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
 
 	retval = smp_call_function_single(cpu,
-				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
+				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
 	if (retval == 0) {
 		retval = cxcc.retval;
 		if (retval == 0) {
--

To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html