Skip to contentSkip to conversation

mmc_spi: fix bug introduced in patch 3/7

PATCH Wolfgang Mües 3 participants 3 messages Mar 12, 2009 – Mar 15, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: Wolfgang Muees <[email protected]>

o Fix bug introduced in patch 3/7.
The first 3 bits of the data response may be undefined; assuming that these bits are always 1 lead to unreliable transmission.

---

drivers/mmc/host/mmc_spi.c +3 -0
diff -uprN 2_6_29_rc7_patch9_speedup/drivers/mmc/host/mmc_spi.c 2_6_29_rc7_patch10_bugfix_of_patch3/drivers/mmc/host/mmc_spi.c
@@ -725,6 +725,9 @@ mmc_spi_writeblock(struct mmc_spi_host *
 	pattern |= scratch->status[2] << 8;
 	pattern |= scratch->status[3];
 
+	/* First 3 bit of pattern are undefined */
+	pattern |= 0xE0000000;
+
 	/* left-adjust to leading 0 bit */
 	while (pattern & 0x80000000)
 		pattern <<= 1;

---
regards

i. A. Wolfgang Mües

Signature · 13 lines
Auerswald GmbH & Co. KG
Hardware Development
Telefon: +49 (0)5306 9219 0
Telefax: +49 (0)5306 9219 94 
E-Mail: [email protected]
Web: http://www.auerswald.de
 
--------------------------------------------------------------
Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRA 13289
p.h.G Auerswald Geschäftsführungsges. mbH
Registriert beim AG Braunschweig HRB 7463
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
#1 lore raw
Quoted 8 lines · Wolfgang Mües

From: Wolfgang Muees <[email protected]>

o Fix bug introduced in patch 3/7.
The first 3 bits of the data response may be undefined; assuming that these bits are always 1 lead to unreliable transmission.

Could you just send an updated version of #3? Addressing both this issue and the previous "comment is confusing" one. I could ack such an update.

Quoted 37 lines

---

diff -uprN 2_6_29_rc7_patch9_speedup/drivers/mmc/host/mmc_spi.c 2_6_29_rc7_patch10_bugfix_of_patch3/drivers/mmc/host/mmc_spi.c

drivers/mmc/host/mmc_spi.c +3 -1
@@ -725,6 +725,9 @@ mmc_spi_writeblock(struct mmc_spi_host *
 	pattern |= scratch->status[2] << 8;
 	pattern |= scratch->status[3];
 
+	/* First 3 bit of pattern are undefined */
+	pattern |= 0xE0000000;
+
 	/* left-adjust to leading 0 bit */
 	while (pattern & 0x80000000)
 		pattern <<= 1;
 
---

regards

i. A. Wolfgang Mües

Signature · 13 lines
Auerswald GmbH & Co. KG
Hardware Development
Telefon: +49 (0)5306 9219 0
Telefax: +49 (0)5306 9219 94 
E-Mail: [email protected]
Web: http://www.auerswald.de
 
--------------------------------------------------------------
Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRA 13289
p.h.G Auerswald Geschäftsführungsges. mbH
Registriert beim AG Braunschweig HRB 7463
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
#2 lore raw
In reply to Wolfgang Mües

I've applied patched 1,2 and 5. The other ones had comments and/or wouldn't apply because of missing earlier patches. So please fix up the things suggested and resend those patches.

Rgds

Signature · 6 lines
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.