Skip to contentSkip to conversation

twl4030-regulator: expose VPLL2

PATCH In review David Brownell 5 participants 6 messages Mar 14, 2009 – Mar 22, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 twl4030-regulator: expose VPLL2

From: David Brownell <[email protected]>

Add VPLL2 to the set of twl4030-family regulators exposed for use by various drivers. It's commonly used to power the digital video outputs (e.g. LCD or DVI displays) on OMAP3 systems.

---
Please apply to regulator-next and linux-omap ... I'll send some patches configuring various OMAP boards to use this.

 drivers/mfd/twl4030-core.c            |    2 --
 drivers/regulator/twl4030-regulator.c |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/mfd/twl4030-core.c +0 -2
@@ -613,11 +613,9 @@ add_children(struct twl4030_platform_dat
 
 	/* maybe add LDOs that are omitted on cost-reduced parts */
 	if (twl_has_regulator() && !(features & TPS_SUBSET)) {
-		/*
 		child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2);
 		if (IS_ERR(child))
 			return PTR_ERR(child);
-		*/
 
 		child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2);
 		if (IS_ERR(child))
drivers/regulator/twl4030-regulator.c +1 -1
@@ -404,8 +404,8 @@ static struct twlreg_info twl4030_regs[]
 	TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
 	/*
 	TWL_ADJUSTABLE_LDO(VPLL1, 0x2f, 7),
-	TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
 	*/
+	TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
 	TWL_ADJUSTABLE_LDO(VSIM, 0x37, 9),
 	TWL_ADJUSTABLE_LDO(VDAC, 0x3b, 10),
 	/*
#1 lore raw
Quoted 33 lines · David Brownell

From: David Brownell <[email protected]>

Add VPLL2 to the set of twl4030-family regulators exposed for use by various drivers. It's commonly used to power the digital video outputs (e.g. LCD or DVI displays) on OMAP3 systems.

---
Please apply to regulator-next and linux-omap ... I'll send some patches configuring various OMAP boards to use this.

 drivers/mfd/twl4030-core.c            |    2 --
 drivers/regulator/twl4030-regulator.c |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/mfd/twl4030-core.c +0 -2
@@ -613,11 +613,9 @@ add_children(struct twl4030_platform_dat
 
 	/* maybe add LDOs that are omitted on cost-reduced parts */
 	if (twl_has_regulator() && !(features & TPS_SUBSET)) {
-		/*
 		child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2);
 		if (IS_ERR(child))
 			return PTR_ERR(child);
-		*/
 
 		child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2);
 		if (IS_ERR(child))

drivers/regulator/twl4030-regulator.c static struct twlreg_info twl4030_regs[] · line 411

Quoted 9 lines
drivers/regulator/twl4030-regulator.c +1 -1
@@ -404,8 +404,8 @@ static struct twlreg_info twl4030_regs[]
 	TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
 	/*
 	TWL_ADJUSTABLE_LDO(VPLL1, 0x2f, 7),
-	TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
 	*/
+	TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
 	TWL_ADJUSTABLE_LDO(VSIM, 0x37, 9),
 	TWL_ADJUSTABLE_LDO(VDAC, 0x3b, 10),
 	/*

Samuel, I'm fine putting this through regulator if its fine with you ?

Thanks

Liam

#3 lore raw
Quoted 10 lines · Mark Brown
Quoted 7 lines · David Brownell

From: David Brownell <[email protected]>

Add VPLL2 to the set of twl4030-family regulators exposed for use by various drivers. It's commonly used to power the digital video outputs (e.g. LCD or DVI displays) on OMAP3 systems.

Samuel, I've applied this to the regulator tree as the part that touches mfd is relatively minor and twl4030 specific (doesn't touch core).

Thanks

Liam

#4 lore raw
Quoted 8 lines · Liam Girdwood
Quoted 7 lines · Mark Brown
Quoted 6 lines · David Brownell

From: David Brownell <[email protected]>

Add VPLL2 to the set of twl4030-family regulators exposed for use by various drivers. It's commonly used to power the digital video outputs (e.g. LCD or DVI displays) on OMAP3 systems.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Samuel, I've applied this to the regulator tree as the part that touches mfd is relatively minor and twl4030 specific (doesn't touch core).

Thanks a lot, and sorry for the late reply...
Feel free to add my Acked-by: if needed.

Cheers,
Samuel.

Quoted 4 lines

Thanks

Liam

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/