Skip to contentSkip to conversation

trace/ring_buffer: fix section mismatch warning

PATCH In review Heiko Carstens 3 participants 5 messages Mar 21, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace/ring_buffer: fix section mismatch warning

From: Heiko Carstens <[email protected]>

With linux-next I get this:

Section mismatch in reference from the function ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify() The function ring_buffer_alloc() references
the function __cpuinit rb_cpu_notify().
This is often because ring_buffer_alloc lacks a __cpuinit
annotation or the annotation of rb_cpu_notify is wrong.

This is a false positive since rb_cpu_notify gets only referenced if CONFIG_HOTPLUG_CPU=y.
To get rid of the warning annotate ring_buffer_alloc with __ref.

---
 kernel/trace/ring_buffer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/ring_buffer.c +1 -1
Index: linux-next/kernel/trace/ring_buffer.c
===================================================================
@@ -549,7 +549,7 @@ static int __cpuinit rb_cpu_notify(struc
  * when the buffer wraps. If this flag is not set, the buffer will
  * drop data when the tail hits the head.
  */
-struct ring_buffer *ring_buffer_alloc(unsigned long size, unsigned flags)
+struct ring_buffer * __ref ring_buffer_alloc(unsigned long size, unsigned flags)
 {
 	struct ring_buffer *buffer;
 	int bsize;
#1 lore raw
Quoted 10 lines · Heiko Carstens

From: Heiko Carstens <[email protected]>

With linux-next I get this:

Section mismatch in reference from the function ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify() The function ring_buffer_alloc() references the function __cpuinit rb_cpu_notify(). This is often because ring_buffer_alloc lacks a __cpuinit annotation or the annotation of rb_cpu_notify is wrong.

Quoted 7 lines

This is a false positive since rb_cpu_notify gets only referenced if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate ring_buffer_alloc with __ref.

---
 kernel/trace/ring_buffer.c |    2 +-

Frederic has beaten you to it narrowly:

09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit

:)

Ingo

#2 lore raw
Quoted 10 lines · On Sat, 21 Mar 2009 15:39:11 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 10 lines

Section mismatch in reference from the function ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify() The function ring_buffer_alloc() references the function __cpuinit rb_cpu_notify(). This is often because ring_buffer_alloc lacks a __cpuinit annotation or the annotation of rb_cpu_notify is wrong.

This is a false positive since rb_cpu_notify gets only referenced if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate ring_buffer_alloc with __ref.

Quoted 7 lines
Quoted 3 lines
---
 kernel/trace/ring_buffer.c |    2 +-

Frederic has beaten you to it narrowly:

09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit

Btw. that was the only section mismatch warning I got on linux-next with an allyesconfig on s390. We probably could enable the verbose section mismatch warnings at compile time?

Sam?

#3 lore raw
Quoted 18 lines · Heiko Carstens
Quoted 16 lines · On Sat, 21 Mar 2009 15:39:11 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 6 lines

Section mismatch in reference from the function ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify() The function ring_buffer_alloc() references the function __cpuinit rb_cpu_notify(). This is often because ring_buffer_alloc lacks a __cpuinit annotation or the annotation of rb_cpu_notify is wrong.

Quoted 7 lines

This is a false positive since rb_cpu_notify gets only referenced if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate ring_buffer_alloc with __ref.

---
 kernel/trace/ring_buffer.c |    2 +-

Frederic has beaten you to it narrowly:

Quoted 7 lines
Quoted 1 line

09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit

Btw. that was the only section mismatch warning I got on linux-next with an allyesconfig on s390. We probably could enable the verbose section mismatch warnings at compile time?

Sam?

There's still too many warnings in general on other platforms - but as long as it's per arch we could in fact propagate the warnings to build failures.

Ingo

#4 lore raw
In reply to Heiko Carstens
Quoted 18 lines · Heiko Carstens
Quoted 16 lines · On Sat, 21 Mar 2009 15:39:11 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 6 lines

Section mismatch in reference from the function ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify() The function ring_buffer_alloc() references the function __cpuinit rb_cpu_notify(). This is often because ring_buffer_alloc lacks a __cpuinit annotation or the annotation of rb_cpu_notify is wrong.

Quoted 7 lines

This is a false positive since rb_cpu_notify gets only referenced if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate ring_buffer_alloc with __ref.

---
 kernel/trace/ring_buffer.c |    2 +-

Frederic has beaten you to it narrowly:

Quoted 7 lines
Quoted 1 line

09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit

Btw. that was the only section mismatch warning I got on linux-next with an allyesconfig on s390. We probably could enable the verbose section mismatch warnings at compile time?

Sam?

When I get a bit more time (and a properly working setup again) I will enable the verbose version.
But until I can dedicate enough time to support it I am not the one to make it more verbose.

That may be in the timeframe of 2.6.30 but I'm not sure.

Sam