PalmLD IDE
Quoted 15 lines
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux napsal(a):
Quoted 8 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Quoted 3 lines
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Thanks
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
Best regards
Marek Vasut
From 8881f9cbf66a3050de328f6c020f864ca04c1e9b Mon Sep 17 00:00:00 2001
From: Marek <[email protected]>
Date: Sat, 16 Aug 2008 16:25:34 +0200
Subject: [PATCH] PalmLD: IDE support
Support for Palm LifeDrive's internal harddrive
--- drivers/ata/Kconfig | 9 +++ drivers/ata/Makefile | 1 + drivers/ata/pata_palmld.c | 145 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 155 insertions(+), 0 deletions(-) create mode 100644 drivers/ata/pata_palmld.c
drivers/ata/Kconfig +9 -0
@@ -533,6 +533,15 @@ config PATA_OPTIDMA If unsure, say N. +config PATA_PALMLD + tristate "Palm LifeDrive PATA support" + depends on MACH_PALMLD + help + This option enables support for Palm LifeDrive's internal ATA + port via the new ATA layer. + + If unsure, say N. + config PATA_PCMCIA tristate "PCMCIA PATA support" depends on PCMCIA
drivers/ata/Makefile +1 -0
@@ -50,6 +50,7 @@ obj-$(CONFIG_PATA_MPC52xx) += pata_mpc52xx.o obj-$(CONFIG_PATA_MARVELL) += pata_marvell.o obj-$(CONFIG_PATA_MPIIX) += pata_mpiix.o obj-$(CONFIG_PATA_OLDPIIX) += pata_oldpiix.o +obj-$(CONFIG_PATA_PALMLD) += pata_palmld.o obj-$(CONFIG_PATA_PCMCIA) += pata_pcmcia.o obj-$(CONFIG_PATA_PDC2027X) += pata_pdc2027x.o obj-$(CONFIG_PATA_PDC_OLD) += pata_pdc202xx_old.o
drivers/ata/pata_palmld.c new file +145 -0
145 lines not on this page · raw message
Signature · 1 line
1.5.6
Quoted 1 line · On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
Quoted 1 line
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
napsal(a):
Quoted 16 lines
Quoted 16 lines
Quoted 8 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Quoted 8 lines
Quoted 1 line
Thanks
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
Best regards
Marek Vasut
It's still being totally ignored on both mailing lists ... why? Thanks
Quoted 21 lines · On Sunday 19 April 2009 18:14:05 Marek Vasut wrote:
Quoted 1 line · On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
Quoted 1 line
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
napsal(a):
Quoted 18 lines
Quoted 17 lines
Quoted 8 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Thanks
Quoted 8 lines
Quoted 6 lines
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
Best regards
Marek VasutIt's still being totally ignored on both mailing lists ... why? Thanks
I don't know the answer for your question but this patch is not for me.
Please take me off cc: list unless you're also going to submit *IDE* driver (sorry, I have no time to review libata patches). Thanks.
Quoted 30 lines · On Monday 20 of April 2009 22:38:38 Bartlomiej Zolnierkiewicz wrote:
Quoted 29 lines · On Sunday 19 April 2009 18:14:05 Marek Vasut wrote:
Quoted 1 line · On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
Quoted 1 line
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
napsal(a):
Quoted 24 lines
Quoted 14 lines
Quoted 8 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Quoted 3 lines
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Thanks
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
Best regards
Marek Vasut
Quoted 6 lines
Quoted 1 line
It's still being totally ignored on both mailing lists ... why? Thanks
I don't know the answer for your question but this patch is not for me.
Please take me off cc: list unless you're also going to submit *IDE* driver (sorry, I have no time to review libata patches). Thanks.
That's good to know, where should I send it then? Thanks
Quoted 31 lines · On Monday 20 April 2009 22:53:06 Marek Vasut wrote:
Quoted 30 lines · On Monday 20 of April 2009 22:38:38 Bartlomiej Zolnierkiewicz wrote:
Quoted 29 lines · On Sunday 19 April 2009 18:14:05 Marek Vasut wrote:
Quoted 1 line · On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
Quoted 1 line
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
napsal(a):
Quoted 24 lines
Quoted 14 lines
Quoted 8 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Quoted 3 lines
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Thanks
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
Best regards
Marek Vasut
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
It's still being totally ignored on both mailing lists ... why? Thanks
I don't know the answer for your question but this patch is not for me.
Please take me off cc: list unless you're also going to submit *IDE* driver (sorry, I have no time to review libata patches). Thanks.
That's good to know, where should I send it then? Thanks
see Cc: :)
Quoted 4 lines
Quoted 2 lines
Please take me off cc: list unless you're also going to submit *IDE* driver (sorry, I have no time to review libata patches). Thanks.
That's good to know, where should I send it then? Thanks
Send it this way for review.
Alan
Quoted 15 lines · Marek Vasut
Quoted 15 lines
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux napsal(a):
Quoted 13 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Quoted 7 lines
Quoted 3 lines
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Thanks
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
I wonder if this driver can be implemented in a more generic way so that other boards can be benefited. The only specific things I see are:
1. I/O mapping address space
2. IRQ
3. PowerON
IRQ can be specified by platform_data, and power_on can be implemented by callbacks in platform_data. I/O mapping should be OK by resources in platform_device.
So what's else to make this specific to PalmLD?
Quoted 2 lines · On Tuesday 21 of April 2009 06:02:59 Eric Miao wrote:
Quoted 1 line · Marek Vasut
Quoted 1 line
Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
napsal(a):
Quoted 29 lines
Quoted 14 lines
Quoted 14 lines
Quoted 13 lines · Marek Vasut
Quoted 2 lines
This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.
I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.
Review
Quoted 2 lines
(quoted diff) +2
-0+static const char drvname[] = "pata_palmld"; +MODULE_ALIAS("platform: "drvname);Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...
Quoted 7 lines
Quoted 3 lines
Ok, I fixed the issues and CCed linux-ide and the maintainer.
Thanks
Hi, Im resending this patch since it was totally ignored last time. It still applies correctly. It'd be for the best to push this through arm-kernel tree.
I wonder if this driver can be implemented in a more generic way so that other boards can be benefited. The only specific things I see are:
1. I/O mapping address space
2. IRQ
3. PowerON
Quoted 5 lines
IRQ can be specified by
platform_data, andpower_oncan be implemented by callbacks inplatform_data. I/O mapping should be OK by resources inplatform_device.So what's else to make this specific to PalmLD?
Will there be anyone who would use that other than palmld then ? I doubt anyone has that obscure hardware. That's why I see no point in making this generic.