Skip to contentSkip to conversation

ar9170: simplify & deBUG tx_status queueing and reporting

PATCH New Christian Lamparter 1 participant 1 message Mar 23, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ar9170: simplify & deBUG tx_status queueing and reporting

This patch simplifies the tx_status report code by using four tx_queues per station instead of only one. (the skb lookup should be in O(1) now :-p ).

Also, it fixes a really obvious copy&paste bug in the janitor work code and adds back a few spilled bits to the hardware definition header about QoS.

---
Alina, does the driver - with this patch - still cause freeze/crash/hangs?

Regards,
Chr
---

drivers/net/wireless/ar9170/ar9170.h +1 -1
index c49d713..f4fb2e9 100644
@@ -159,7 +159,7 @@ struct ar9170 {
 };
 
 struct ar9170_sta_info {
-	struct sk_buff_head tx_status;
+	struct sk_buff_head tx_status[__AR9170_NUM_TXQ];
 };
 
 #define IS_STARTED(a)		(a->state >= AR9170_STARTED)
drivers/net/wireless/ar9170/hw.h +11 -0
index ad205f8..231d347 100644
@@ -397,10 +397,21 @@ struct ar9170_cmd_response {
 	};
 } __packed;
 
+/* QoS */
+
 /* mac80211 queue to HW/FW map */
 static const u8 ar9170_qos_hwmap[4] = { 3, 2, 0, 1 };
 
 /* HW/FW queue to mac80211 map */
 static const u8 ar9170_qos_mac80211map[4] = { 2, 3, 1, 0 };
 
+enum ar9170_txq {
+	AR9170_TXQ_BE,
+	AR9170_TXQ_BK,
+	AR9170_TXQ_VI,
+	AR9170_TXQ_VO,
+
+	__AR9170_NUM_TXQ,
+};
+
 #endif /* __AR9170_HW_H */
drivers/net/wireless/ar9170/main.c +37 -102

225 lines not on this page · raw message