Skip to contentSkip to conversation

sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process

PATCH In review ideawu 2 participants 2 messages Mar 26, 2009 – Mar 27, 2009

lore
Share & tools
lore

ideawu

author
#0 lore raw

PATCH 1/1 sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process

There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.

--------

sunrpc/svc.mod.c renamed from sunrpc/svc.c +0 -1
@@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
 	procp = versp->vs_proc + proc;
 	if (proc >= versp->vs_nproc || !procp->pc_func)
 		goto err_bad_proc;
-	rqstp->rq_server   = serv;
 	rqstp->rq_procinfo = procp;
 
 
#1 lore raw
Quoted 1 line · ideawu

There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.

Thanks! Applied.

sunrpc/svc.mod.c

Quoted 6 lines

--------

sunrpc/svc.mod.c renamed from sunrpc/svc.c +0 -0

(But next time please make sure the patch applies with 'patch -p1').

--b.

Quoted 9 lines
sunrpc/svc.mod.c renamed from sunrpc/svc.c +0 -1
@@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
 	procp = versp->vs_proc + proc;
 	if (proc >= versp->vs_nproc || !procp->pc_func)
 		goto err_bad_proc;
-	rqstp->rq_server   = serv;
 	rqstp->rq_procinfo = procp;