Skip to contentSkip to conversation

USB: serial: add symbol serial driver

DISCUSSION Alan Cox 2 participants 3 messages Mar 26, 2009 – Apr 6, 2009 1 message not in the archive

lore
Share & tools
lore

Alan Cox

author
#1 lore raw
In reply to a message not in the archive

On Thu, 26 Mar 2009 19:29:28 GMT
Linux Kernel Mailing List <[email protected]> wrote:

Thank you for not running this past the tty layer maintainer.

Review

Quoted 7 lines
(quoted diff) +7 -0
+	/*
+	 * Force low_latency on so that our tty_push actually forces the data
+	 * through, otherwise it is scheduled, and with high data rates (like
+	 * with OHCI) data can get lost.
+	 */
+	if (tty)
+		tty->low_latency = 1;

The above is bogus cargo cult programming copied from old drivers and should be removed.

Otherwise looks fine

#2 lore raw
Quoted 4 lines · Alan Cox

On Thu, 26 Mar 2009 19:29:28 GMT
Linux Kernel Mailing List <[email protected]> wrote:

Thank you for not running this past the tty layer maintainer.

Sorry about that.

Quoted 10 lines

Review

Quoted 7 lines
(quoted diff) +7 -0
+	/*
+	 * Force low_latency on so that our tty_push actually forces the data
+	 * through, otherwise it is scheduled, and with high data rates (like
+	 * with OHCI) data can get lost.
+	 */
+	if (tty)
+		tty->low_latency = 1;

The above is bogus cargo cult programming copied from old drivers and should be removed.

It's all over the usb-serial drivers, should I just remove it from all of them?

thanks,

greg k-h

author
#3 lore raw
Quoted 5 lines
Quoted 2 lines

The above is bogus cargo cult programming copied from old drivers and should be removed.

It's all over the usb-serial drivers, should I just remove it from all of them?

I think so yes. USB folks used it to avoid overrunning the old flip buffer system and with proper buffering that isn't needed. Now its only relevance is if you need very low latency responses which is normally an application layer choice.

Alan