cx88: Missing failure checks
PATCH 1/1 cx88: Missing failure checks
The ioremap one was reported in October 2007 (Bug 9146), the kmalloc one was blindingly obvious while looking at the ioremap one
The bug suggests some other configuration for lots of I/O memory (32MB per device is ioremapped) but I'll leave that to the real maintainers
Signed-off-by Alan Cox <[email protected]>
---
drivers/media/video/cx88/cx88-cards.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/media/video/cx88/cx88-cards.c +7 -0
@@ -3089,6 +3089,8 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr)int i; core =kzalloc (sizeof (*core),GFP_KERNEL ); +if (core ==NULL ) +return NULL ;atomic_inc (&core->refcount); core->pci_bus = pci->bus->number;
@@ -3110,6 +3112,11 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr) core->lmmio =ioremap (pci_resource_start (pci,0 ),pci_resource_len (pci,0 )); core->bmmio = (u8 __iomem *)core->lmmio; + +if (core->lmmio ==NULL ) { +kfree (core); +return NULL ; + }/* board config */ core->boardnr =UNSET ;