Out-of-tree build for imx31_phycore_eet fails
Dear Guennadi,
out-of-tree building for the imx31_phycore_eet target fails:
-> make O=/work/wd/tmp-arm imx31_phycore_eet_config/bin/sh: line 1: /work/wd/tmp-arm/include/config.h: No such file or directory
make: *** [imx31_phycore_eet_config] Error 1
Please fix.
BTW: you also forgot to add your name to the MAINTAINERS file. Please fix this, too.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de When a program is being tested, it is too late to make design changes. -- Geoffrey James, "The Tao of Programming"
Hi Wolfgang,
Quoted 7 lines · Wolfgang Denk
Dear Guennadi,
out-of-tree building for the
imx31_phycore_eettarget fails:-> make O=/work/wd/tmp-arm
imx31_phycore_eet_config/bin/sh: line 1: /work/wd/tmp-arm/include/config.h: No such file or directory
make: *** [imx31_phycore_eet_config] Error 1
ok, that's just a missing
+ @mkdir -p $(obj)include
right? will submit.
Quoted 4 lines
Please fix.
BTW: you also forgot to add your name to the
MAINTAINERSfile. Please fix this, too.
Hm, this is not a new board, just a new configuration for an existing board. Do we really want a new MAINTAINERS entry for it? I looked at a couple other boards with multiple configs, they all had only one entry in MAINTAINERS (at most:-)).
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
Dear Guennadi,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 3 lines
/bin/sh: line 1: /work/wd/tmp-arm/include/config.h: No such file or directory
make: *** [imx31_phycore_eet_config] Error 1ok, that's just a missing
(quoted diff) +1
-0+ @mkdir -p $(obj)includeright? will submit.
Thanks.
Quoted 9 lines
Quoted 4 lines
Please fix.
BTW: you also forgot to add your name to the
MAINTAINERSfile. Please fix this, too.Hm, this is not a new board, just a new configuration for an existing board. Do we really want a new
MAINTAINERSentry for it? I looked at a couple other boards with multiple configs, they all had only one entry inMAINTAINERS(at most:-)).
I see. I thought that was a new board.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There are some things worth dying for. -- Kirk, "Errand of Mercy", stardate 3201.7
Hi,
Quoted 20 lines
Dear Guennadi,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 3 lines
/bin/sh: line 1: /work/wd/tmp-arm/include/config.h: No such file or directory
make: *** [imx31_phycore_eet_config] Error 1ok, that's just a missing
(quoted diff) +1
-0+ @mkdir -p $(obj)includeright? will submit.
Thanks.
Quoted 5 lines
Quoted 4 lines
Please fix.
BTW: you also forgot to add your name to the
MAINTAINERSfile. Please fix this, too.
Quoted 6 lines
Quoted 4 lines
Hm, this is not a new board, just a new configuration for an existing board. Do we really want a new
MAINTAINERSentry for it? I looked at a couple other boards with multiple configs, they all had only one entry inMAINTAINERS(at most:-)).I see. I thought that was a new board.
But I find this case to be different - the maintainer of the imx31_phycore (Sascha Hauer) has never seen the eet hardware, so how is he supposed to maintain the code?
The other examples Guennadi mentions usually were all done by the same person.
In summary I vote for adding Guennadi as maintainer for the eet variant.
Cheers
Detlev
Signature · 6 lines
-- Question authority! -- Yeah, says who? -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de