s3fb: fix color component length for pseudocolor modes
PATCH 1/1 s3fb: fix color component length for pseudocolor modes
s3fb incorrectly sets the length of the color fields to 6 bits for PSEUDOCOLOR modes, even though 8 or 4 bits are used per pixel. Fix this by setting the length to 8 or 4, respectively.
Signed-off-by Michal Januszewski <[email protected]>
---
drivers/video/s3fb.c +3 -3
@@ -45,11 +45,11 @@ struct s3fb_info {static const struct svga_fb_format s3fb_formats[] = { {0 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_TEXT ,FB_AUX_TEXT_SVGA_STEP4 ,FB_VISUAL_PSEUDOCOLOR ,8 ,16 }, - {4 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },0 , + {4 , {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_PACKED_PIXELS ,0 ,FB_VISUAL_PSEUDOCOLOR ,8 ,16 }, - {4 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },1 , + {4 , {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,0 ,0 },1 ,FB_TYPE_INTERLEAVED_PLANES ,1 ,FB_VISUAL_PSEUDOCOLOR ,8 ,16 }, - {8 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },0 , + {8 , {0 ,8 ,0 }, {0 ,8 ,0 }, {0 ,8 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_PACKED_PIXELS ,0 ,FB_VISUAL_PSEUDOCOLOR ,4 ,8 }, {16 , {10 ,5 ,0 }, {5 ,5 ,0 }, {0 ,5 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_PACKED_PIXELS ,0 ,FB_VISUAL_TRUECOLOR ,2 ,4 },
Quoted 5 lines · Michal Januszewski
s3fb incorrectly sets the length of the color fields to 6 bits for PSEUDOCOLOR modes, even though 8 or 4 bits are used per pixel. Fix this by setting the length to 8 or 4, respectively.
Signed-off-by Michal Januszewski <[email protected]>
Acked-by Ondrej Zajicek <[email protected]>
Quoted 21 lines
---
drivers/video/s3fb.c +3
-3@@ -45,11 +45,11 @@ struct s3fb_info {static const struct svga_fb_format s3fb_formats[] = { {0 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_TEXT ,FB_AUX_TEXT_SVGA_STEP4 ,FB_VISUAL_PSEUDOCOLOR ,8 ,16 }, - {4 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },0 , + {4 , {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_PACKED_PIXELS ,0 ,FB_VISUAL_PSEUDOCOLOR ,8 ,16 }, - {4 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },1 , + {4 , {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,4 ,0 }, {0 ,0 ,0 },1 ,FB_TYPE_INTERLEAVED_PLANES ,1 ,FB_VISUAL_PSEUDOCOLOR ,8 ,16 }, - {8 , {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,6 ,0 }, {0 ,0 ,0 },0 , + {8 , {0 ,8 ,0 }, {0 ,8 ,0 }, {0 ,8 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_PACKED_PIXELS ,0 ,FB_VISUAL_PSEUDOCOLOR ,4 ,8 }, {16 , {10 ,5 ,0 }, {5 ,5 ,0 }, {0 ,5 ,0 }, {0 ,0 ,0 },0 ,FB_TYPE_PACKED_PIXELS ,0 ,FB_VISUAL_TRUECOLOR ,2 ,4 },
Signature · 5 lines
Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: [email protected]) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."