Skip to contentSkip to conversation

UV system table in bios accessed after unmap

PATCH In review Russ Anderson 1 participant 2 messages Mar 30, 2009 – Apr 3, 2009

Subsystems (2)
x86 Linux-next tree
lore
Share & tools
lore

Russ Anderson

author
#0 lore raw

PATCH 1/1 UV system table in bios accessed after unmap

Use the copy of UV system table in kernel memory, not the one in bios after unmapping.

Signed-off-by Russ Anderson <[email protected]>
---
 arch/x86/kernel/bios_uv.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kernel/bios_uv.c +2 -1
Index: linux-next/arch/x86/kernel/bios_uv.c
===================================================================
@@ -182,7 +182,8 @@ void uv_bios_init(void)
 	memcpy(&uv_systab, tab, sizeof(struct uv_systab));
 	iounmap(tab);
 
-	printk(KERN_INFO "EFI UV System Table Revision %d\n", tab->revision);
+	printk(KERN_INFO "EFI UV System Table Revision %d\n",
+					uv_systab.revision);
 }
 #else	/* !CONFIG_EFI */
Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          [email protected]
author
#1 lore raw

[tip:x86/uv] x86, UV: system table in bios accessed after unmap

Commit-ID:  1a544e659cbfce178395e9a090a47d1907d0cfa8
Gitweb:     http://git.kernel.org/tip/1a544e659cbfce178395e9a090a47d1907d0cfa8
Author:     Russ Anderson <[email protected]>
AuthorDate: Mon, 30 Mar 2009 17:52:40 -0500
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 3 Apr 2009 19:25:57 +0200

x86, UV: system table in bios accessed after unmap

Use the copy of UV system table in kernel memory, not the one in bios after unmapping.

Signed-off-by Russ Anderson <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Ingo Molnar <[email protected]>
---
 arch/x86/kernel/bios_uv.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/x86/kernel/bios_uv.c +2 -1
index f638827..63a88e1 100644
@@ -182,7 +182,8 @@ void uv_bios_init(void)
 	memcpy(&uv_systab, tab, sizeof(struct uv_systab));
 	iounmap(tab);
 
-	printk(KERN_INFO "EFI UV System Table Revision %d\n", tab->revision);
+	printk(KERN_INFO "EFI UV System Table Revision %d\n",
+					uv_systab.revision);
 }
 #else	/* !CONFIG_EFI */