Skip to contentSkip to conversation

hso: add Vendor/Product ID's for new devices

PATCH In review Jan Dumon 5 participants 5 messages Mar 31, 2009 – Apr 1, 2009 2 messages not in the archive

Subsystems (4)
lore
Share & tools
lore

Jan Dumon

author
#0 lore raw

PATCH 1/1 hso: add Vendor/Product ID's for new devices

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.

---

drivers/net/usb/hso.c +9 -2
index fe98aca..d47c508 100644
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);
#1 lore raw
Quoted 11 lines · Jan Dumon

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.

---

drivers/net/usb/hso.c +0 -0
index fe98aca..d47c508 100644

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 466

Quoted 5 lines
drivers/net/usb/hso.c +0 -2
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},

Please add comment in description why you are removing these IDs.

Quoted 13 lines
drivers/net/usb/hso.c +9 -0
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);
#3 lore raw
In reply to a message not in the archive
Quoted 5 lines · Paulius Zaleckas
Quoted 4 lines · Jan Dumon

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.

Quoted 14 lines

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 466

Quoted 12 lines

---

drivers/net/usb/hso.c +0 -2
index fe98aca..d47c508 100644
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},

Please add comment in description why you are removing these IDs.

No ID's are removed.
0xd057 is added again by the same patch, 0x7361 was twice in the list.

Quoted 5 lines
Quoted 5 lines
drivers/net/usb/hso.c +4 -0
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
Quoted 8 lines

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 477

Quoted 8 lines
drivers/net/usb/hso.c +5 -0
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw
In reply to a message not in the archive

From: Paulius Zaleckas <[email protected]>
Date: Wed, 01 Apr 2009 10:33:59 +0300

Quoted 9 lines

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 466

Quoted 6 lines · Jan Dumon
drivers/net/usb/hso.c +0 -2
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},

Please add comment in description why you are removing these IDs.

This isn't the first time they've been asked to do this.

--------------------

Subject: Re: [PATCH] hso: add new device id's
From: David Miller <davem-fT/PcQaiUtIeIZ0/[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Date: Mon, 02 Feb 2009 16:33:00 -0800 (PST)
X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)

From: "Filip Aben" <[email protected]>
Date: Tue, 3 Feb 2009 01:26:14 +0100

Quoted 12 lines
Quoted 11 lines
(quoted diff) +0 -1
-----Original Message-----

From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/[email protected]]
Sent: maandag 2 februari 2009 23:03
To: Filip Aben
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] hso: add new device id's

Why won't 0xaf0/0xd051 ever be used?

You should explain such things in your commit message, that way I don't have to ask.

Quoted 6 lines

That ID was used in an internal engineering version of a device and will never see commercial light.
Even if this ID will be 'recycled' in the future, which is very unlikely,
I don't know what kind of device will be behind it. Therefore it's safer to remove it.

Great, please add that information to the commit message and resend your patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw
In reply to a message not in the archive
Quoted 20 lines · Jan Dumon
Quoted 5 lines · Paulius Zaleckas
Quoted 4 lines · Jan Dumon

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.

Quoted 13 lines

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 466

Quoted 12 lines

---

drivers/net/usb/hso.c +0 -2
index fe98aca..d47c508 100644
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},

Please add comment in description why you are removing these IDs.

Quoted 2 lines

No ID's are removed.
0xd057 is added again by the same patch, 0x7361 was twice in the list.

OK for 0xd057, but please add comment that you are removing duplicate definition of 0x7361.

Quoted 15 lines
Quoted 14 lines
Quoted 4 lines
drivers/net/usb/hso.c +3 -0
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 477

Quoted 10 lines
drivers/net/usb/hso.c +6 -0
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html