Skip to contentSkip to conversation

hso: add Vendor/Product ID's for new devices

PATCH Applied Jan Dumon 4 participants 4 messages Apr 1, 2009 – Apr 2, 2009 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

Jan Dumon

author
#0 lore raw

PATCH 1/1 hso: add Vendor/Product ID's for new devices

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.
Removed duplicate product ID 0x7361.

---

drivers/net/usb/hso.c +9 -2
index fe98aca..d47c508 100644
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);
#1 lore raw
Quoted 20 lines · Jan Dumon

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.
Removed duplicate product ID 0x7361.

---

drivers/net/usb/hso.c +3 -2
index fe98aca..d47c508 100644
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 477

Quoted 10 lines
drivers/net/usb/hso.c +6 -0
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);

Is this list supposed to be kept in numerical order? The entries for 0xd057 and 0xd157 are in the wrong place.

Alan Stern

#3 lore raw
In reply to a message not in the archive
Quoted 27 lines · Alan Stern
Quoted 25 lines · Jan Dumon

From: Jan Dumon <[email protected]>

Add Vendor/Product ID's for new devices.
Removed duplicate product ID 0x7361.

---

drivers/net/usb/hso.c +7 -2
index fe98aca..d47c508 100644
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
Quoted 8 lines

drivers/net/usb/hso.c static const struct usb_device_id hso_ids[] = { · line 477

Quoted 5 lines
drivers/net/usb/hso.c +2 -0
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);

Is this list supposed to be kept in numerical order? The entries for 0xd057 and 0xd157 are in the wrong place.

We have an internal document with all the product ID's we use and I've followed that order. That way it's a lot easier for me to compare the two and spot the missing ID's every time the list gets updated.

The devices with ID's 0x[0-2]55 are all from the same 'family' as are those with ID's 0x[0-3]57. That is why they are out of numerical order...

Greets,
Jan.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html