Skip to contentSkip to conversation

cpm_uart: Initialize port.dev before it's used.

PATCH Applied Scott Wood 2 participants 2 messages Apr 3, 2009 – Apr 6, 2009

lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH 1/1 cpm_uart: Initialize port.dev before it's used.

Previously, this caused NULL to sometimes be passed as a device to the DMA code. With recent DMA changes, that now causes a BUG().

---
This is a regression triggered by DMA changes; please apply for 2.6.30.

 drivers/serial/cpm_uart/cpm_uart_core.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/serial/cpm_uart/cpm_uart_core.c +3 -3
index 5c6ef51..4dd00be 100644
@@ -1339,13 +1339,13 @@ static int __devinit cpm_uart_probe(struct of_device *ofdev,
 
 	dev_set_drvdata(&ofdev->dev, pinfo);
 
+	/* initialize the device pointer for the port */
+	pinfo->port.dev = &ofdev->dev;
+
 	ret = cpm_uart_init_port(ofdev->node, pinfo);
 	if (ret)
 		return ret;
 
-	/* initialize the device pointer for the port */
-	pinfo->port.dev = &ofdev->dev;
-
 	return uart_add_one_port(&cpm_reg, &pinfo->port);
 }
 
Signature · 1 line
1.5.6.rc1.6.gc53ad.dirty
Applied
#1 lore raw
Quoted 6 lines · Scott Wood

Previously, this caused NULL to sometimes be passed as a device to the DMA code. With recent DMA changes, that now causes a BUG().

---
This is a regression triggered by DMA changes; please apply for 2.6.30.

applied

- k