Don't censor output
PATCH 1/1 Don't censor output
For reasons that neither Arnd nor I can remember, the s390 port of checkstack happened to ignore stack frames below 300 and above 10000 bytes. Later on the same effect - arguably a bug - was copied into the arm, ia64, mips and sh64 ports.
Fixing it also makes the regular expressions shorter and simpler.
---
scripts/checkstack.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
scripts/checkstack.pl renamed from scripts/checkstack.pl~checkstack +6 -6
@@ -38,7 +38,7 @@ my (@stack, $re, $x, $xs); $xs = "[0-9a-f ]"; # hex character or space if ($arch eq 'arm') { #c0008ffc: e24dd064 sub sp, sp, #100 ; 0x64 - $re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o; + $re = qr/.*sub.*sp, sp, #([0-9]{1,8})/o; } elsif ($arch eq 'avr32') { #8000008a: 20 1d sub sp,4 #80000ca8: fa cd 05 b0 sub sp,sp,1456
@@ -51,17 +51,17 @@ my (@stack, $re, $x, $xs); $re = qr/^.*[as][du][db] \$(0x$x{1,8}),\%rsp$/o; } elsif ($arch eq 'ia64') { #e0000000044011fc: 01 0f fc 8c adds r12=-384,r12 - $re = qr/.*adds.*r12=-(([0-9]{2}|[3-9])[0-9]{2}),r12/o; + $re = qr/.*adds.*r12=-([0-9]{1,8}),r12/o; } elsif ($arch eq 'm68k') { # 2b6c: 4e56 fb70 linkw %fp,#-1168 # 1df770: defc ffe4 addaw #-28,%sp $re = qr/.*(?:linkw %fp,|addaw )#-([0-9]{1,4})(?:,%sp)?$/o; } elsif ($arch eq 'mips64') { #8800402c: 67bdfff0 daddiu sp,sp,-16 - $re = qr/.*daddiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o; + $re = qr/.*daddiu.*sp,sp,-([0-9]{1,8})/o; } elsif ($arch eq 'mips') { #88003254: 27bdffe0 addiu sp,sp,-32 - $re = qr/.*addiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o; + $re = qr/.*addiu.*sp,sp,-([0-9]{1,8})/o; } elsif ($arch eq 'parisc' || $arch eq 'parisc64') { $re = qr/.*ldo ($x{1,8})\(sp\),sp/o; } elsif ($arch eq 'ppc') {
@@ -74,13 +74,13 @@ my (@stack, $re, $x, $xs); $re = qr/.*st[dw]u.*r1,-($x{1,8})\(r1\)/o; } elsif ($arch =~ /^s390x?$/) { # 11160: a7 fb ff 60 aghi %r15,-160 - $re = qr/.*ag?hi.*\%r15,-(([0-9]{2}|[3-9])[0-9]{2})/o; + $re = qr/.*ag?hi.*\%r15,-([0-9]{1,8})/o; } elsif ($arch =~ /^sh64$/) { #XXX: we only check for the immediate case presently, # though we will want to check for the movi/sub # pair for larger users. -- PFM. #a00048e0: d4fc40f0 addi.l r15,-240,r15 - $re = qr/.*addi\.l.*r15,-(([0-9]{2}|[3-9])[0-9]{2}),r15/o; + $re = qr/.*addi\.l.*r15,-([0-9]{1,8}),r15/o; } elsif ($arch =~ /^blackfin$/) { # 0: 00 e8 38 01 LINK 0x4e0; $re = qr/.*[[:space:]]LINK[[:space:]]*(0x$x{1,8})/o;
Quoted 1 line · On Mon, 6 Apr 2009 23:11:46 +0200 J__rn Engel <[email protected]> wrote:
Subject: [PATCH][Checkstack] Don't censor output
Please use the form
subsytem-identifier: what-i-did-to-it
so
[patch] checkstack: don't censor output
would suit here.
scripts/checkstack.pl
Quoted 15 lines
Date: Mon, 6 Apr 2009 23:11:46 +0200
User-Agent: Mutt/1.5.13 (2006-08-11)For reasons that neither Arnd nor I can remember, the s390 port of checkstack happened to ignore stack frames below 300 and above 10000 bytes. Later on the same effect - arguably a bug - was copied into the arm, ia64, mips and sh64 ports.
Fixing it also makes the regular expressions shorter and simpler.
scripts/checkstack.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)scripts/checkstack.pl renamed from scripts/checkstack.pl~checkstack +0
-0
The patch fails to apply, yet nobody has changed checkstack.pl in ages. I think you're tricking me.