RxRPC: Error handling for rxrpc_alloc_connection()
Subsystems (2)
David Howells
maintainerPATCH 1/1 RxRPC: Error handling for rxrpc_alloc_connection()
From: Dan Carpenter <[email protected]>
rxrpc_alloc_connection() doesn't return an error code on failure, it just returns NULL. IS_ERR(NULL) is false.
Signed-off-by Dan Carpenter <[email protected]>
Signed-off-by David Howells <[email protected]>
---
net/rxrpc/ar-connection.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
net/rxrpc/ar-connection.c +6 -6
@@ -343,9 +343,9 @@ static int rxrpc_connect_exclusive(struct rxrpc_sock *rx,/* not yet present - create a candidate for a new connection * and then redo the check */ conn =rxrpc_alloc_connection (gfp); -if (IS_ERR (conn)) { -_leave (" = %ld" ,PTR_ERR (conn)); -return PTR_ERR (conn); +if (!conn) { +_leave (" = -ENOMEM" ); +return -ENOMEM ; } conn->trans = trans;
@@ -508,9 +508,9 @@ int rxrpc_connect_call(struct rxrpc_sock *rx,/* not yet present - create a candidate for a new connection and then * redo the check */ candidate =rxrpc_alloc_connection (gfp); -if (IS_ERR (candidate)) { -_leave (" = %ld" ,PTR_ERR (candidate)); -return PTR_ERR (candidate); +if (!candidate) { +_leave (" = -ENOMEM" ); +return -ENOMEM ; } candidate->trans = trans;