Skip to contentSkip to conversation

New build error?

PATCH In review Russell King - ARM Linux 3 participants 3 messages Apr 7, 2009 – Apr 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64

omap_hsmmc: Fix response type for busy after response

Error:

drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'

Please submit a fix to Pierre for this, thanks.

#1 lore raw

PATCH 1/1 mmc: Fix compile for omap_hsmmc.c (Re: New build error?)

Quoted 10 lines · Russell King - ARM Linux

Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64

omap_hsmmc: Fix response type for busy after response

Error:

drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'

Please submit a fix to Pierre for this, thanks.

Thanks for notifying about this. Pierre, here's a fix for this.

Tony

Quoted 1 line

From 880d2674e036b566f5596bef1b45911508cd37a1 Mon Sep 17 00:00:00 2001

From: Tony Lindgren <[email protected]>
Date: Tue, 7 Apr 2009 17:04:33 -0700
Subject: [PATCH] mmc: Fix compile for omap_hsmmc.c

This fixes the issue noted by Russell King:

drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'

This got broken by 4a694dc915c9a223044ce21fc0d99e63facd1d64.

drivers/mmc/host/omap_hsmmc.c +0 -1
index a752788..d765df2 100644
@@ -298,7 +298,6 @@ mmc_omap_xfer_done(struct mmc_omap_host *host, struct mmc_data *data)
 		struct mmc_request *mrq = host->mrq;
 
 		host->mrq = NULL;
-		mmc_omap_fclk_lazy_disable(host);
 		mmc_request_done(host->mmc, mrq);
 		return;
 	}
#2 lore raw

Re: [PATCH] mmc: Fix compile for omap_hsmmc.c (Re: New build error?)

Quoted 5 lines · On Tue, 7 Apr 2009 17:13:27 -0700 Tony Lindgren <[email protected]> wrote:
Quoted 4 lines · Russell King - ARM Linux

Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64

omap_hsmmc: Fix response type for busy after response

Quoted 9 lines
Quoted 6 lines

Error:

drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'

Please submit a fix to Pierre for this, thanks.

Thanks for notifying about this. Pierre, here's a fix for this.

Queued.

Signature · 6 lines
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.