Skip to contentSkip to conversation

i2c: Let new-style drivers implement attach_adapter

PATCH In review Jean Delvare 2 participants 2 messages Apr 10, 2009 – Apr 15, 2009 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: Let new-style drivers implement attach_adapter

While it isn't the way the standard device binding model works, it is OK for new-style drivers to implement attach_adapter. It may help convert the renaming legacy drivers to new style drivers faster.

Cc David Brownell <[email protected]>

---
Johannes, you'll need to apply this patch before you can test the onyx/tas conversion patch I sent to you yesterday.

 drivers/i2c/i2c-core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/i2c-core.c +1 -2
@@ -716,8 +716,7 @@ int i2c_register_driver(struct module *o
 
 	/* new style driver methods can't mix with legacy ones */
 	if (is_newstyle_driver(driver)) {
-		if (driver->attach_adapter || driver->detach_adapter
-				|| driver->detach_client) {
+		if (driver->detach_adapter || driver->detach_client) {
 			printk(KERN_WARNING
 					"i2c-core: driver [%s] is confused\n",
 					driver->driver.name);
Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 3 lines · Jean Delvare

While it isn't the way the standard device binding model works, it is OK for new-style drivers to implement attach_adapter. It may help convert the renaming legacy drivers to new style drivers faster.

s/renaming/remaining

Quoted 2 lines
Cc David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org>