Skip to contentSkip to conversation

ath: add module information

PATCH Superseded Christian Lamparter 5 participants 8 messages Apr 13, 2009 – Apr 14, 2009 Atheros ath generic utilities

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath: add module information

This patch adds licensing information, description and author to the module.

---
Luis,

what does your secretary say?
As we are "borrowing" dual licensed code and I guess Atheros wants to keep their code "this way", right?

Regards,
Chr
---

drivers/net/wireless/ath/Makefile +1 -2
index a005b91..4bb0132 100644
@@ -3,5 +3,4 @@ obj-$(CONFIG_ATH9K)		+= ath9k/
 obj-$(CONFIG_AR9170_USB)        += ar9170/
 
 obj-$(CONFIG_ATH_COMMON)	+= ath.o
-ath-objs 		:= regd.o
-
+ath-objs 		:= main.o regd.o
drivers/net/wireless/ath/main.c new file +33 -0
new file mode 100644
index 0000000..c5eb144
@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2008-2009 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+MODULE_AUTHOR("Atheros Communications");
+MODULE_DESCRIPTION("Shared library for Atheros wireless LAN cards.");
+MODULE_LICENSE("Dual BSD/GPL");
+
+static int __init ath_init(void)
+{
+	return 0;
+}
+module_init(ath_init);
+
+static void __exit ath_exit(void)
+{
+}
+module_exit(ath_exit);
#1 lore raw

drivers/net/wireless/ath/Makefile obj-$(CONFIG_ATH9K) += ath9k/ · line 6

Quoted 11 lines · Christian Lamparter
drivers/net/wireless/ath/Makefile +1 -2
index a005b91..4bb0132 100644
@@ -3,5 +3,4 @@ obj-$(CONFIG_ATH9K)		+= ath9k/
 obj-$(CONFIG_AR9170_USB)        += ar9170/
 
 obj-$(CONFIG_ATH_COMMON)	+= ath.o
-ath-objs 		:= regd.o
-
+ath-objs 		:= main.o regd.o

why do you put that in a different file and not in ath.c?

Quoted 39 lines
drivers/net/wireless/ath/main.c new file +33 -0
new file mode 100644
index 0000000..c5eb144
@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2008-2009 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+MODULE_AUTHOR("Atheros Communications");
+MODULE_DESCRIPTION("Shared library for Atheros wireless LAN cards.");
+MODULE_LICENSE("Dual BSD/GPL");
+
+static int __init ath_init(void)
+{
+	return 0;
+}
+module_init(ath_init);
+
+static void __exit ath_exit(void)
+{
+}
+module_exit(ath_exit);
#2 lore raw
Quoted 2 lines · maximilian attems

drivers/net/wireles=

Quoted 1 line · Christian Lamparter
drivers/net/wireles= renamed from drivers/net/wireless/ath/Makefile +0 -0

s/ath/Makefile

Quoted 4 lines

drivers/net/wireless/ath/Makefile obj-$(CONFIG_ATH9K) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=

Quoted 4 lines

index a005b91..4bb0132 100644

drivers/net/wireless/ath/Makefile +0 -0
@@ -3,5 +3,4 @@ obj-$(CONFIG_ATH9K) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=

+=3D ath9k/

Quoted 1 line
Quoted 1 line

=C2=A0obj-$(CONFIG_AR9170_USB) =C2=A0 =C2=A0 =C2=A0 =C2=A0+=3D ar917=

0/

Quoted 5 lines

drivers/net/wireless/ath/Makefile

Quoted 5 lines

=C2=A0obj-$(CONFIG_ATH_COMMON) =C2=A0 =C2=A0 +=3D ath.o

drivers/net/wireless/ath/Makefile +1 -2
-ath-objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :=3D regd.o
-
+ath-objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :=3D main.o regd=

=2Eo

Quoted 2 lines

why do you put that in a different file and not in ath.c?

Apart from this objection, looks good -- and thanks.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 1 line · Luis R. Rodriguez

On Mon, Apr 13, 2009 at 1:44 PM, maximilian attems <[email protected]> wrot=

e:

Quoted 2 lines
Quoted 2 lines · Christian Lamparter

drivers/net/wirele=

Quoted 1 line
drivers/net/wirele= renamed from drivers/net/wireless/ath/Makefile +0 -0

ss/ath/Makefile

Quoted 4 lines
Quoted 4 lines

drivers/net/wireless/ath/Makefile obj-$(CONFIG_ATH9K) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=

Quoted 4 lines

index a005b91..4bb0132 100644

drivers/net/wireless/ath/Makefile +0 -0
@@ -3,5 +3,4 @@ obj-$(CONFIG_ATH9K) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=

=A0 +=3D ath9k/

Quoted 1 line
Quoted 1 line
Quoted 1 line

=C2=A0obj-$(CONFIG_AR9170_USB) =C2=A0 =C2=A0 =C2=A0 =C2=A0+=3D ar91=

70/

Quoted 5 lines
Quoted 5 lines

drivers/net/wireless/ath/Makefile

Quoted 5 lines

=C2=A0obj-$(CONFIG_ATH_COMMON) =C2=A0 =C2=A0 +=3D ath.o

drivers/net/wireless/ath/Makefile +1 -2
-ath-objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :=3D regd.o
-
+ath-objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :=3D main.o reg=

d.o

Quoted 4 lines
Quoted 2 lines

why do you put that in a different file and not in ath.c?

Apart from this objection, looks good -- and thanks.

Actually a new file makes sense -- we might later add more stuff other than regulatory. That is the idea.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
In reply to Luis R. Rodriguez
Quoted 3 lines · Luis R. Rodriguez
Quoted 1 line

why do you put that in a different file and not in ath.c?

Apart from this objection, looks good -- and thanks.

Because there is no ath.c? :)

I like it, thanks Christian.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
#5 lore raw
In reply to maximilian attems
Quoted 8 lines · On Monday 13 April 2009 22:44:30 maximilian attems wrote:
Quoted 7 lines · Christian Lamparter
drivers/net/wireless/ath/Makefile +0 -0
index a005b91..4bb0132 100644
@@ -3,5 +3,4 @@ obj-$(CONFIG_ATH9K)		+= ath9k/
 obj-$(CONFIG_AR9170_USB)        += ar9170/
 
Quoted 6 lines

drivers/net/wireless/ath/Makefile obj-$(CONFIG_ATH9K) += ath9k/ · line 6

Quoted 4 lines
drivers/net/wireless/ath/Makefile +1 -2
 obj-$(CONFIG_ATH_COMMON)	+= ath.o
-ath-objs 		:= regd.o
-
+ath-objs 		:= main.o regd.o

why do you put that in a different file and not in ath.c?

which ath.c?

besides, is this possible?
as kbuild will then generate two ath.o
- one from ath.c.
- when all ath-objs are merged into ath.o so we end up reading & writing to the same file?!

Regards,
Chr

#6 lore raw
In reply to Christian Lamparter

drivers/net/wireless/ath/main.c line 33

Quoted 10 lines
drivers/net/wireless/ath/main.c new file +10 -0
+static int __init ath_init(void)
+{
+	return 0;
+}
+module_init(ath_init);
+
+static void __exit ath_exit(void)
+{
+}
+module_exit(ath_exit);

No need for these.

#7 lore raw

PATCH v2 1/1 ath: add module information

This patch adds licensing, author information and a description to the module.

---

Quoted 3 lines · On Tuesday 14 April 2009 13:58:43 Christoph Hellwig wrote:
Quoted 1 line

[module_init & module_exit stubs]

No need for these.

OK! will remove the ones in p54common.c too.
---

drivers/net/wireless/ath/Makefile +1 -2
index a005b91..4bb0132 100644
@@ -3,5 +3,4 @@ obj-$(CONFIG_ATH9K)		+= ath9k/
 obj-$(CONFIG_AR9170_USB)        += ar9170/
 
 obj-$(CONFIG_ATH_COMMON)	+= ath.o
-ath-objs 		:= regd.o
-
+ath-objs 		:= main.o regd.o
drivers/net/wireless/ath/main.c new file +22 -0
new file mode 100644
index 0000000..c5eb144
@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2009 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+MODULE_AUTHOR("Atheros Communications");
+MODULE_DESCRIPTION("Shared library for Atheros wireless LAN cards.");
+MODULE_LICENSE("Dual BSD/GPL");