Skip to contentSkip to conversation

Btrfs: setting variable out of order

PATCH In review Eugene Teo 2 participants 2 messages Apr 15, 2009 Btrfs file system

lore
Share & tools
lore

Eugene Teo

author
#0 lore raw

PATCH 1/1 Btrfs: setting variable out of order

This doesn't look intentional.

---
 fs/btrfs/ctree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/ctree.c +0 -0
index e5b2533..6aa2468 100644
@@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct

btrfs_trans_handle *trans,

        for (i = 0; i < nr; i++) {
                if (total_size + data_size[i] + sizeof(struct btrfs_item) >
                    BTRFS_LEAF_DATA_SIZE(root)) {
-                       break;
                        nr = i;
+                       break;
               	}
                total_data += data_size[i];
                total_size += data_size[i] + sizeof(struct btrfs_item);
#1 lore raw
Quoted 12 lines · Eugene Teo

This doesn't look intentional.

---
 fs/btrfs/ctree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/ctree.c +0 -0
index e5b2533..6aa2468 100644

fs/btrfs/ctree.c int btrfs_insert_some_items(struct · line 3382

Quoted 8 lines
fs/btrfs/ctree.c +1 -1
@@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
 btrfs_trans_handle *trans,
        for (i = 0; i < nr; i++) {
                if (total_size + data_size[i] + sizeof(struct btrfs_item) >
                    BTRFS_LEAF_DATA_SIZE(root)) {
-                       break;
                        nr = i;
+                       break;
               	}

Thanks,

This function isn't used anymore, I'll drop it.

-chris