Skip to contentSkip to conversation

pxa2xx_spi: fix kernel freeze regression

PATCH New David Brownell 1 participant 1 message Apr 16, 2009 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pxa2xx_spi: fix kernel freeze regression

From: Daniel Ribeiro <[email protected]>

The "introduce chipselect GPIO" patch introduced a serious regression in the PXA SPI driver, for boards not using that new mechanism. On one board this caused a kernel frees on system startup.

Fix is trivial: correct typo on pxa2xx-spi.c cs_deassert.

---
 drivers/spi/pxa2xx_spi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/pxa2xx_spi.c +1 -1
@@ -195,7 +195,7 @@ static void cs_deassert(struct driver_da
 	struct chip_data *chip = drv_data->cur_chip;
 
 	if (chip->cs_control) {
-		chip->cs_control(PXA2XX_CS_ASSERT);
+		chip->cs_control(PXA2XX_CS_DEASSERT);
 		return;
 	}
 

------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p