Skip to contentSkip to conversation

mpt2sas: T10 DIF Support - EEDP

PATCH Eric Moore 2 participants 2 messages Apr 16, 2009 – Apr 17, 2009 SCSI

lore
Share & tools
lore

Eric Moore

author
#0 lore raw
Quoted 7 lines · Martin K. Petersen

For Type 1 I expect you to check guard + match ref tag to CDB LBA + offset.

For Type 2 I expect you to check guard + match ref tag to E.I.LBA in 32-byte CDB + offset.

For Type 3 I expect you to check guard only.

Does this patch look good?

(1) I modified _scsih_setup_eedp so for TYPE1, its sets ref and gaurd checking, and for TYPE2 it sets gauard checking.

(2) I removed the calling of scsi_host_set_guard.

I'll repost the entire patch set if this is good to go.

Eric Moore

drivers/scsi/mpt2sas/mpt2sas_base.h +1 -0
diff -uaprN a/drivers/scsi/mpt2sas/mpt2sas_base.h b/drivers/scsi/mpt2sas/mpt2sas_base.h
@@ -61,6 +61,7 @@
 #include <scsi/scsi_tcq.h>
 #include <scsi/scsi_transport_sas.h>
 #include <scsi/scsi_dbg.h>
+#include <scsi/scsi_eh.h>
 
 #include "mpt2sas_debug.h"
drivers/scsi/mpt2sas/mpt2sas_scsih.c +118 -0

148 lines not on this page · raw message

Reviewed-by
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Eric" == Eric Moore <[email protected]> writes:

Eric,

Eric> (1) I modified _scsih_setup_eedp so for TYPE1, its sets ref and
Eric> gaurd checking, and for TYPE2 it sets gauard checking.

You mean Type 3 and not Type 2. But yes, looks ok.

Feel free to add:

Reviewed-by Martin K. Petersen <[email protected]>
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering