Skip to contentSkip to conversation

Rename qemu into qemu-system-i386 and install a compat symlink

RFC PATCH Superseded Aurelien Jarno 8 participants 12 messages Apr 18, 2009 – Apr 19, 2009 Kbuild

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 Rename qemu into qemu-system-i386 and install a compat symlink

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

---
 Makefile.target |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
Makefile.target +3 -4
index dae339b..88c7a32 100644
@@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
 QEMU_PROG=qemu-$(TARGET_ARCH2)
 else
 # system emulator name
-ifeq ($(TARGET_ARCH), i386)
-QEMU_PROG=qemu$(EXESUF)
-else
 QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
 endif
-endif
 
 PROGS=$(QEMU_PROG)
 
@@ -743,6 +739,9 @@ install: all
 ifneq ($(PROGS),)
 	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
 endif
+ifeq ($(TARGET_ARCH), i386)
+	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
+endif
 
 # Include automatically generated dependency files
 -include $(wildcard *.d */*.d)
Signature · 6 lines
1.6.1.3


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net
#1 lore raw
Quoted 8 lines · Aurelien Jarno

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

I agree.

Regards,

Anthony Liguori

Quoted 33 lines
---
 Makefile.target |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
Makefile.target +3 -4
index dae339b..88c7a32 100644
@@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
 QEMU_PROG=qemu-$(TARGET_ARCH2)
 else
 # system emulator name
-ifeq ($(TARGET_ARCH), i386)
-QEMU_PROG=qemu$(EXESUF)
-else
 QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
 endif
-endif
 
 PROGS=$(QEMU_PROG)
 
@@ -743,6 +739,9 @@ install: all
 ifneq ($(PROGS),)
 	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
 endif
+ifeq ($(TARGET_ARCH), i386)
+	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
+endif
 
 # Include automatically generated dependency files
 -include $(wildcard *.d */*.d)
#2 lore raw
Quoted 10 lines · Anthony Liguori
Quoted 8 lines · Aurelien Jarno

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

Quoted 6 lines

I agree.

Regards,

Anthony Liguori

I agree partially.

For the current situation, qemu-system-i386 is reasonable, and a symbolic link to qemu for non-Windows platforms is a good solution.

For the (maybe far) future, I'd prefer to have a qemu executable which is either a frontend to the different user and system emulation executables or which replaces all these executables.

This new qemu could auto-detect the target architecture from -M (cpu parameter) or from ELF file argument. It could also auto-detect user or system mode. Calling the correct backend qemu-xxx is then straight forward.

And finally, keeping qemu (with enhanced functionality) would also allow to keep the existing documentation unchanged:
qemu-doc.texi has lots of references to qemu!

Regards,

Stefan Weil

#3 lore raw

2009/4/19 Stefan Weil <[email protected]>:

Quoted 3 lines

For the current situation, qemu-system-i386 is reasonable, and a symbolic link to qemu for non-Windows platforms is a good solution.

Another point is that if you just download the new qemu tarball, build it and install, the old /usr/local/bin/qemu binary will not be overwritten if we don't create the symlink and a number of poeple will think they're on a newer version than they're really using.

Cheers

#4 lore raw
In reply to Aurelien Jarno

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

Quoted 9 lines

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

In general a good idea imo, but don't just assume you can create symlinks on a given file system. Git uses hardlinks and copying as fallbacks iirc.

Andreas

Quoted 41 lines

---
Makefile.target | 7 +++----

1 files changed, 3 insertions(+), 4 deletions(-)
Makefile.target +0 -0
index dae339b..88c7a32 100644
@@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
 QEMU_PROG=qemu-$(TARGET_ARCH2)

else

# system emulator name
Makefile.target +0 -3
-ifeq ($(TARGET_ARCH), i386)
-QEMU_PROG=qemu$(EXESUF)
-else

QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
endif
-endif

PROGS=$(QEMU_PROG)

Makefile.target +0 -0
@@ -743,6 +739,9 @@ install: all
 ifneq ($(PROGS),)
 	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"

endif

Makefile.target +3 -0
+ifeq ($(TARGET_ARCH), i386)
+	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
+endif

# Include automatically generated dependency files -include $(wildcard *.d */*.d)

Signature · 6 lines
1.6.1.3


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net
#5 lore raw
Quoted 11 lines · Andreas Färber

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

Quoted 8 lines

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

Quoted 5 lines
Quoted 1 line

In general a good idea imo, but don't just assume you can create symlinks on a given file system. Git uses hardlinks and copying as fallbacks iirc.

For hardlinks that's clear. For symlinks, what (file)systems are you thinking of?

Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net
#6 lore raw
Quoted 15 lines · Aurelien Jarno
Quoted 13 lines · Andreas Färber

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

Quoted 10 lines

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

Quoted 7 lines
Quoted 4 lines

In general a good idea imo, but don't just assume you can create symlinks on a given file system. Git uses hardlinks and copying as fallbacks iirc.

For hardlinks that's clear. For symlinks, what (file)systems are you thinking of?

NTFS?

#7 lore raw
Quoted 21 lines · Stefan Weil
Quoted 20 lines · Aurelien Jarno
Quoted 17 lines · Andreas Färber

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

Quoted 10 lines

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

In general a good idea imo, but don't just assume you can create symlinks on a given file system. Git uses hardlinks and copying as fallbacks iirc.

Quoted 4 lines
Quoted 2 lines

For hardlinks that's clear. For symlinks, what (file)systems are you thinking of?

NTFS?

Can someone tries what ln does on such a system? We may do a copy instead in that case.

Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net
#8 lore raw
Quoted 25 lines · Aurelien Jarno
Quoted 23 lines · Stefan Weil
Quoted 21 lines · Aurelien Jarno
Quoted 18 lines · Andreas Färber

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

Quoted 11 lines

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

In general a good idea imo, but don't just assume you can create symlinks on a given file system. Git uses hardlinks and copying as fallbacks iirc.

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

For hardlinks that's clear. For symlinks, what (file)systems are you thinking of?

NTFS?

Can someone tries what ln does on such a system? We may do a copy instead in that case.

Windows has a concept of shortcuts (.lnk files). Cygwin's ln creates a shortcut to simulate a symbolic link. MSYS implements 'ln -s' by doing a file copy. I don't think it works for directories.

I'm not personally opposed to just getting rid of 'qemu' for the 0.11 release. Sure, there will be some management tools that look for 'qemu' instead of 'qemu-system-i386' but I doubt they'll change things until the symlink goes away.

We can issue a big fat ANNOUNCE to the mailing list that for 0.11 the executable name will change. Since it won't be for a few months, that should give people time to adjust.

Regards,

Anthony Liguori

#9 lore raw

----- Message d'origine ----

Quoted 34 lines

De : Anthony Liguori <[email protected]>
À : [email protected]
Envoyé le : Dimanche, 19 Avril 2009, 0h11mn 49s
Objet : Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

Quoted 12 lines · Aurelien Jarno
Quoted 10 lines · Stefan Weil
Quoted 8 lines · Aurelien Jarno
Quoted 6 lines · Andreas Färber

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

Quoted 3 lines

For historical reasons, qemu system on i386 is called qemu instead of qemu-system-i386. This seems to confuse users.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

Signed-off-by Aurelien Jarno

In general a good idea imo, but don't just assume you can create symlinks

on a given file system. Git uses hardlinks and copying as fallbacks iirc.

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

For hardlinks that's clear. For symlinks, what (file)systems are you thinking of?

NTFS?

Quoted 8 lines
Quoted 3 lines

Can someone tries what ln does on such a system? We may do a copy instead in that case.

Windows has a concept of shortcuts (.lnk files). Cygwin's ln creates a shortcut to simulate a symbolic link. MSYS implements 'ln -s' by doing a file copy. I don't think it works for directories.

For directories, you have NTFS junctions. 'Linked' directories appear as actual directories in the filesystem.

#10 lore raw
Quoted 8 lines · Sylvain Petreolle
Quoted 5 lines

Windows has a concept of shortcuts (.lnk files). Cygwin's ln creates a shortcut to simulate a symbolic link. MSYS implements 'ln -s' by doing a file copy. I don't think it works for directories.

For directories, you have NTFS junctions. 'Linked' directories appear as actual directories in the filesystem.

Windows and NTFS actually have several kinds of link types, resembling symbolic and hard links, apart from .LNK files and junctions. They kept adding more with each version of Windows.

But I doubt if simply losing 'qemu.exe' will cause any great tragedy for Windows users.

-- Jamie

#11 lore raw
In reply to Aurelien Jarno
Quoted 7 lines · Aurelien Jarno

For historical reasons, qemu system on i386 is called qemu instead of
qemu-system-i386. This seems to confuse users.

This patch installs it as qemu-system-i386, and create a compatibility symlink qemu -> qemu-system-i386 as some tools may call it that way. We can change or remove this symlink after a few releases when all the tools have migrated to this new name.

Reasonable change to me too.

Quoted 20 lines

---

  Makefile.target |    7 +++----
  1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Makefile.target b/Makefile.target
index dae339b..88c7a32 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
QEMU_PROG=qemu-$(TARGET_ARCH2)
else

  # system emulator name
 -ifeq ($(TARGET_ARCH), i386)
 -QEMU_PROG=qemu$(EXESUF)
 -else
  QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
  endif
 -endif
Quoted 8 lines
  PROGS=$(QEMU_PROG)

@@ -743,6 +739,9 @@ install: all
ifneq ($(PROGS),)

        $(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"

endif
+ifeq ($(TARGET_ARCH), i386)
+ ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"

IIRC '-f' (force) provided by some lns was actually very weak, so you'd have to use rm first.