Skip to contentSkip to conversation

Please revert console ASCII glyph 1:1 mapping

PATCH New Samuel Thibault 1 participant 1 message Apr 18, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Please revert console ASCII glyph 1:1 mapping

This reverts commit 1c55f187 (console ASCII glyph 1:1 mapping): Ingo was assuming that reverting to 1:1 mapping for chars >= 128 was not useful, but it happens to be: due to the limitations of the Linux console, when a blind user wants to read BIG5 on it, he has no other way than loading a font without SFM and let the 1:1 mapping permit the screen reader to get the BIG5 encoding.

reverted:

drivers/char/vt.c +1 -1
@@ -2274,7 +2274,7 @@
 				    continue; /* nothing to display */
 				}
 				/* Glyph not found */
+				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) || c < 128) && !(c & ~charmask)) {
-				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) && c < 128) && !(c & ~charmask)) {
 				    /* In legacy mode use the glyph we get by a 1:1 mapping.
 				       This would make absolutely no sense with Unicode in mind,
 				       but do this for ASCII characters since a font may lack