Skip to contentSkip to conversation

x86: more than 8 32-bit CPUs requires X86_BIGSMP

PATCH Michael K. Johnson 1 participant 2 messages Apr 22, 2009 x86

lore
Share & tools
lore
#0 lore raw
$ cat x86-more-than-8-cpus-requires-bigsmp.patch

Enforce NR_CPUS <= 8 limitation if X86_BIGSMP not set

Configuring more than 8 logical CPUs on 32-bit x86 requires X86_BIGSMP to be set in order to boot successfully, if more than 8 logical CPUs are actually found at boot time. The X86_BIGSMP help text describes that it is required to be set if more than 8 CPUs are configured, but this was previously not enforced.

This configuration error has affected multiple distributions:

    https://bugzilla.redhat.com/show_bug.cgi?id=480844
    https://issues.rpath.com/browse/RPL-3022
arch/x86/Kconfig +1 -0
index c9086e6..cdad0d9 100644
@@ -664,6 +664,7 @@ config MAXSMP
 
 config NR_CPUS
 	int "Maximum number of CPUs" if SMP && !MAXSMP
+	range 2 8 if SMP && X86_32 && !X86_BIGSMP
 	range 2 512 if SMP && !MAXSMP
 	default "1" if !SMP
 	default "4096" if MAXSMP
#1 lore raw
Commit-ID:  2a3313f494c2f3f74a27d66f0f14b38558b7dba2
Gitweb:     http://git.kernel.org/tip/2a3313f494c2f3f74a27d66f0f14b38558b7dba2
Author:     Michael K. Johnson <[email protected]>
AuthorDate: Tue, 21 Apr 2009 21:44:48 -0400
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Tue, 21 Apr 2009 19:34:54 -0700

x86: more than 8 32-bit CPUs requires X86_BIGSMP

$ cat x86-more-than-8-cpus-requires-bigsmp.patch

Enforce NR_CPUS <= 8 limitation if X86_BIGSMP not set

Configuring more than 8 logical CPUs on 32-bit x86 requires X86_BIGSMP to be set in order to boot successfully, if more than 8 logical CPUs are actually found at boot time. The X86_BIGSMP help text describes that it is required to be set if more than 8 CPUs are configured, but this was previously not enforced.

This configuration error has affected multiple distributions:

    https://bugzilla.redhat.com/show_bug.cgi?id=480844
    https://issues.rpath.com/browse/RPL-3022

LKML-Reference: <[email protected]>

---
 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/Kconfig +1 -0
index c9086e6..b5cda6c 100644
@@ -664,6 +664,7 @@ config MAXSMP
 
 config NR_CPUS
 	int "Maximum number of CPUs" if SMP && !MAXSMP
+	range 2 8 if SMP && X86_32 && !X86_BIGSMP
 	range 2 512 if SMP && !MAXSMP
 	default "1" if !SMP
 	default "4096" if MAXSMP