Skip to contentSkip to conversation

i2c: Do not probe for TV chips on Voodoo3 adapters

PATCH In review Jean Delvare 2 participants 2 messages Apr 25, 2009 – Apr 26, 2009 1 message not in the archive

Subsystems (2)
Framebuffer layer I2C subsystem host drivers
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 i2c: Do not probe for TV chips on Voodoo3 adapters

There's no point in giving the I2C bus of Voodoo3 adapters a class value, there's no video chip driver checking for it anymore. If support is ever needed, the video device should be instantiated explicitly rather than probed.

To the best of my knowledge the only video chip that can be found on these boards is a BT869 video encoder, for which no support exists currently.

Signed-off-by Jean Delvare <[email protected]>
Cc Krzysztof Helt <[email protected]>
---
 drivers/i2c/busses/i2c-voodoo3.c |    1 -
 drivers/video/tdfxfb.c           |    1 -
 2 files changed, 2 deletions(-)
drivers/i2c/busses/i2c-voodoo3.c +0 -1
@@ -163,7 +163,6 @@ static struct i2c_algo_bit_data voo_i2c_
 
 static struct i2c_adapter voodoo3_i2c_adapter = {
 	.owner		= THIS_MODULE,
-	.class		= I2C_CLASS_TV_ANALOG, 
 	.name		= "I2C Voodoo3/Banshee adapter",
 	.algo_data	= &voo_i2c_bit_data,
 };
drivers/video/tdfxfb.c +0 -1
@@ -1315,7 +1315,6 @@ static int __devinit tdfxfb_setup_i2c_bu
 
 	strlcpy(chan->adapter.name, name, sizeof(chan->adapter.name));
 	chan->adapter.owner		= THIS_MODULE;
-	chan->adapter.class		= I2C_CLASS_TV_ANALOG;
 	chan->adapter.algo_data		= &chan->algo;
 	chan->adapter.dev.parent	= dev;
 	chan->algo.setsda		= tdfxfb_i2c_setsda;
Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 5 lines · On Sat, 25 Apr 2009 17:27:08 +0200 Jean Delvare…

There's no point in giving the I2C bus of Voodoo3 adapters a class value, there's no video chip driver checking for it anymore. If support is ever needed, the video device should be instantiated explicitly rather than probed.

Quoted 7 lines

To the best of my knowledge the only video chip that can be found on these boards is a BT869 video encoder, for which no support exists currently.

Signed-off-by Jean Delvare <[email protected]>
Cc Krzysztof Helt <[email protected]>

---

Acked-by Krzysztof Helt <[email protected]>

Wygraj lot balonem dla dwoch osob!
Wejdz >> http://link.interia.pl/f2141