Skip to contentSkip to conversation

davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC )

PATCH New David Brownell 3 participants 3 messages Apr 28, 2009 – May 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC )

From: David Brownell <[email protected]>

Remove CONFIG_SYS_DAVINCI_BROKEN_ECC option. It's not just nasty; it's also unused by any current boards, and doesn't even match the main U-Boot distributions from TI (which use soft ECC, or 4-bit ECC on newer chips that support it).

DaVinci GIT kernels since 2.6.24, and mainline Linux since 2.6.30, match non-BROKEN code paths for 1-bit HW ECC. The BROKEN code paths do seem to partially match what MontaVista/TI kernels (4.0/2.6.10, and 5.0/2.6.18) do ... but only for small pages. Large page support is really broken (and it's unclear just what software it was trying to match!), and the ECC layout was making three more bytes available for use by filesystem (or whatever) code.

Since this option itself seems broken, remove it. Add a comment about the MV/TI compat issue, and the most straightforward way to address it (should someone really need to solve it).

---
 doc/README.nand                          |    9 -
 drivers/mtd/nand/davinci_nand.c          |  218 +----------------------------
 include/asm-arm/arch-davinci/nand_defs.h |   69 ---------
 3 files changed, 13 insertions(+), 283 deletions(-)
doc/README.nand +0 -9
@@ -101,15 +101,6 @@ Configuration Options:
    CONFIG_SYS_NAND_MAX_CHIPS
       The maximum number of NAND chips per device to be supported.
 
-   CONFIG_SYS_DAVINCI_BROKEN_ECC
-      Versions of U-Boot <= 1.3.3 and Montavista Linux kernels
-      generated bogus ECCs on large-page NAND. Both large and small page
-      NAND ECCs were incompatible with the Linux davinci git tree (since
-      NAND was integrated in 2.6.24).
-      Turn this ON if you want backwards compatibility.
-      Turn this OFF if you want U-Boot and the Linux davinci git kernel
-      to use the same ECC format.
-
 NOTE:
 =====
 
drivers/mtd/nand/davinci_nand.c +13 -205

263 lines not on this page · raw message

include/asm-arm/arch-davinci/nand_defs.h +0 -69

73 lines not on this page · raw message

#1 lore raw

PATCH 2/2 davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC )

Quoted 15 lines · David Brownell

From: David Brownell <[email protected]>

Remove CONFIG_SYS_DAVINCI_BROKEN_ECC option. It's not just nasty; it's also unused by any current boards, and doesn't even match the main U-Boot distributions from TI (which use soft ECC, or 4-bit ECC on newer chips that support it).

DaVinci GIT kernels since 2.6.24, and mainline Linux since 2.6.30, match non-BROKEN code paths for 1-bit HW ECC. The BROKEN code paths do seem to partially match what MontaVista/TI kernels (4.0/2.6.10, and 5.0/2.6.18) do ... but only for small pages. Large page support is really broken (and it's unclear just what software it was trying to match!), and the ECC layout was making three more bytes available for use by filesystem (or whatever) code.

Quoted 6 lines

Since this option itself seems broken, remove it. Add a comment about the MV/TI compat issue, and the most straightforward way to address it (should someone really need to solve it).

---

Noone seems to worry about it

maybe cc the linux davinci ML to announce that we remove it could be nice Scoot is it ok with you

Otherwise

Best Regards,
J.

#2 lore raw

PATCH 2/2 davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC )

Quoted 4 lines · Jean-Christophe PLAGNIOL-VILLARD

Noone seems to worry about it

maybe cc the linux davinci ML to announce that we remove it could be nice Scoot is it ok with you

Yes, I've already applied it to "next".

BTW, it's "Scott", not "Scoot". :-)

-Scott