: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’

PATCH Applied Sergey Senozhatsky 2 participants 2 messages Apr 30, 2009 – May 1, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Sergey Senozhatsky

author

2009-04-30 19:29 UTC #0 lore raw

PATCH 1/1 : fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’

Trivial: fixing gcc 4.4 compiler warning:
drivers/net/cxgb3/t3_hw.c: In function ‘t3_prep_adapter’:
drivers/net/cxgb3/t3_hw.c:3782: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’

Signed-off-by Sergey Senozhatsky <[email protected]>

---

drivers/net/cxgb3/t3_hw.c +1 -1

index e1bd690..4f68aeb 100644
@@ -3779,7 +3779,7 @@ int t3_prep_adapter(struct adapter *adapter, const struct adapter_info *ai,
 
 	adapter->params.info = ai;
 	adapter->params.nports = ai->nports0 + ai->nports1;
-	adapter->params.chan_map = !!ai->nports0 | (!!ai->nports1 << 1);
+	adapter->params.chan_map = (!!ai->nports0) | (!!ai->nports1 << 1);
 	adapter->params.rev = t3_read_reg(adapter, A_PL_REV);
 	/*
 	 * We used to only run the "adapter check task" once a second if

David Miller

maintainer Applied

2009-05-01 16:15 UTC #1 lore raw

From: Sergey Senozhatsky <[email protected]>
Date: Thu, 30 Apr 2009 09:06:16 +0300

Quoted 5 lines

Trivial: fixing gcc 4.4 compiler warning:
drivers/net/cxgb3/t3_hw.c: In function ‘t3_prep_adapter’:
drivers/net/cxgb3/t3_hw.c:3782: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
Signed-off-by Sergey Senozhatsky <[email protected]>

Applied, thanks.