Skip to contentSkip to conversation

in_suspend and __nosave

DISCUSSION Sam Ravnborg 3 participants 3 messages Apr 30, 2009 – May 3, 2009

lore
Share & tools
lore
#0 lore raw

Hi Rafael & Linus.

While unifying vmlinux.lds for x86 I stumbled
over the .data.nosave section.

Searching a bit I found only a single user:

swsusp.c:int in_suspend __nosavedata = 0;

Do we really needs all this complexity for this single integer? We have this section defined in several arch lds files.

I understand that in_suspend is special as in that we do not want the value restored while resuming.
But is there no other way to do so today?

All I want is to kill a lot from the vmlinux.lds files.

It also occur to me that only: x86, powerpc, and sh implement pfn_is_nosave() which I think is the only place where we decide if we want to save a page or not.

But we define the .data.nosave section in following architectures:
arm, m32r, mips, mn10300, parisc, s390 in addition to the above archs that define pfn_is_nosave(). Is this something to be cleaned up?

Sam

#1 lore raw
Quoted 1 line · Sam Ravnborg

Hi Rafael & Linus.

Hi,

Quoted 5 lines

While unifying vmlinux.lds for x86 I stumbled
over the .data.nosave section.

Searching a bit I found only a single user:

Quoted 8 lines

swsusp.c:int in_suspend __nosavedata = 0;

Do we really needs all this complexity for this single integer? We have this section defined in several arch lds files.

I understand that in_suspend is special as in that we do not want the value restored while resuming.
But is there no other way to do so today?

On x86-64 we can probably get rid of it, a little code rework is needed for this purpose. Unfortunately some more work is required to do the same thing on x86-32.

Quoted 1 line

All I want is to kill a lot from the vmlinux.lds files.

Well, removing the __nosavedata is on my todo list, but not on the top of it.

Quoted 9 lines

It also occur to me that only: x86, powerpc, and sh implement pfn_is_nosave() which I think is the only place where we decide if we want to save a page or not.

But we define the .data.nosave section in following architectures:
arm, m32r, mips, mn10300, parisc, s390 in addition to the above archs that define pfn_is_nosave(). Is this something to be cleaned up?

Yes, it is.

Thanks,
Rafael

#2 lore raw
In reply to Sam Ravnborg

Hi!

Quoted 9 lines

While unifying vmlinux.lds for x86 I stumbled
over the .data.nosave section.

Searching a bit I found only a single user:

swsusp.c:int in_suspend __nosavedata = 0;

Do we really needs all this complexity for this single integer? We have this section defined in several arch lds files.

Well, original idea was that drivers may need some memory that's not affected by hibernation/restore....

Quoted 9 lines

It also occur to me that only: x86, powerpc, and sh implement pfn_is_nosave() which I think is the only place where we decide if we want to save a page or not.

But we define the .data.nosave section in following architectures:
arm, m32r, mips, mn10300, parisc, s390 in addition to the above archs that define pfn_is_nosave(). Is this something to be cleaned up?

I guess people were just too happy with cut&paste. Ouch and someone was working on arm hibernation, iIRC.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html