Skip to contentSkip to conversation

net: Add the FCoE Initialization Protocol ethertype

PATCH In review Robert Love 2 participants 5 messages May 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: Add the FCoE Initialization Protocol ethertype

FIP is the FCoE Initialization Protocol and this patch adds the protocol ethertype to the kernel's list of ethertypes.

---

 include/linux/if_ether.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/if_ether.h +1 -0
index cfe4fe1..60e8934 100644
@@ -79,6 +79,7 @@
 #define ETH_P_AOE	0x88A2		/* ATA over Ethernet		*/
 #define ETH_P_TIPC	0x88CA		/* TIPC 			*/
 #define ETH_P_FCOE	0x8906		/* Fibre Channel over Ethernet  */
+#define ETH_P_FIP	0x8914		/* FCoE Initialization Protocol */
 #define ETH_P_EDSA	0xDADA		/* Ethertype DSA [ NOT AN OFFICIALLY REGISTERED ID ] */
 
 /*
#2 lore raw
Quoted 11 lines · David Miller

From: Robert Love <[email protected]>
Date: Fri, 01 May 2009 11:55:32 -0700

Quoted 5 lines

FIP is the FCoE Initialization Protocol and this patch adds the protocol ethertype to the kernel's list of ethertypes.

You can add this value, when you add the protocol implementation into the upstream sources.

The FIP implementation is upstream, in drivers/scsi/libfcoe.c. There is a local define in include/scsi/fc/fc_fip.h for ETH_P_FCOE and I'd rather move it to the propper location.

include/scsi/fc/fc_fip.h:28:#ifndef ETH_P_FIP
include/scsi/fc/fc_fip.h:29:#define ETH_P_FIP 0x8914 /* FIP Ethertype */

One thing to note is that I will later push a patch to linux-scsi to remove the define in fc_fip.h. It may be preferable to do both operations in one patch, but I was worried about cross-subsystem conflicts with other patches to either netdev or fcoe code. I can refresh this patch to include the fc_fip.h removal and you and James can decide who takes the patch if that's a better aproach.

maintainer Acked-by
#3 lore raw

From: "Love, Robert W" <[email protected]>
Date: Fri, 1 May 2009 15:53:32 -0700

Quoted 3 lines

The FIP implementation is upstream, in drivers/scsi/libfcoe.c. There is a local define in include/scsi/fc/fc_fip.h for ETH_P_FCOE and I'd rather move it to the propper location.

Then add that local definition removal to your patch so there is no mystery about what this is used for.

Quoted 2 lines

I can refresh this patch to include the fc_fip.h removal and you and James can decide who takes the patch if that's a better aproach.

That works much better, and to avoid merge issues you can send it via James with my pre-ack:

#4 lore raw
Quoted 10 lines · David Miller

From: "Love, Robert W" <[email protected]>
Date: Fri, 1 May 2009 15:53:32 -0700

Quoted 3 lines

The FIP implementation is upstream, in drivers/scsi/libfcoe.c. There is a local define in include/scsi/fc/fc_fip.h for ETH_P_FCOE and I'd rather move it to the propper location.

Then add that local definition removal to your patch so there is no mystery about what this is used for.

Quoted 7 lines
Quoted 2 lines

I can refresh this patch to include the fc_fip.h removal and you and James can decide who takes the patch if that's a better aproach.

That works much better, and to avoid merge issues you can send it via James with my pre-ack:

Will do, thanks.