Skip to contentSkip to conversation

(void*) cast removal

PATCH Applied Chris Sanford 2 participants 3 messages May 3, 2009 – May 27, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 (void*) cast removal

This is a trivial patch that removes an unnecessary void pointer cast. This is my first time submitting a patch so I am unsure who else to send it to. Should this also be sent to the trivial mailling list?

---

sound/oss/msnd.c +1 -1
@@ -100,7 +100,7 @@ void msnd_fifo_free(msnd_fifo *f)
 int msnd_fifo_alloc(msnd_fifo *f, size_t n)
 {
 	msnd_fifo_free(f);
-	f->data = (char *)vmalloc(n);
+	f->data = vmalloc(n);
 	f->n = n;
 	f->tail = 0;
 	f->head = 0;
#1 lore raw

It was suggested I also send this to trivial....

Quoted 24 lines

This is a trivial patch that removes an unnecessary void pointer cast. This is my first time submitting a patch so I am unsure who else to send it to. Should this also be sent to the trivial mailling list?

---

sound/oss/msnd.c +1 -2
@@ -100,7 +100,7 @@ void msnd_fifo_free(msnd_fifo *f)
 int msnd_fifo_alloc(msnd_fifo *f, size_t n)
 {
 	msnd_fifo_free(f);
-	f->data = (char *)vmalloc(n);
+	f->data = vmalloc(n);
 	f->n = n;
 	f->tail = 0;
 	f->head = 0;
--

To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#2 lore raw
In reply to Chris Sanford
Quoted 10 lines · Chris Sanford

It was suggested I also send this to trivial....

Quoted 8 lines

This is a trivial patch that removes an unnecessary void pointer cast. This is my first time submitting a patch so I am unsure who else to send it to. Should this also be sent to the trivial mailling list?

---

Quoted 12 lines

sound/oss/msnd.c void msnd_fifo_free(msnd_fifo *f)

Quoted 12 lines
sound/oss/msnd.c +1 -2
@@ -100,7 +100,7 @@ void msnd_fifo_free(msnd_fifo *f)
 int msnd_fifo_alloc(msnd_fifo *f, size_t n)
 {
 	msnd_fifo_free(f);
-	f->data = (char *)vmalloc(n);
+	f->data = vmalloc(n);
 	f->n = n;
 	f->tail = 0;
 	f->head = 0;
--

I have applied the patch to trivial tree, thanks Chris.

Signature · 2 lines
Jiri Kosina
SUSE Labs