Skip to contentSkip to conversation

i386: ifdef out struct thread_struct::fs

PATCH Applied Alexey Dobriyan 1 participant 2 messages May 3, 2009 – May 11, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 i386: ifdef out struct thread_struct::fs

After commit 464d1a78fbf8cf6c7fd970e7b3e2db50a320ce28 aka "[PATCH] i386: Convert i386 PDA code to use %fs"
%fs saved during context switch moved from thread_struct to pt_regs and value on thread_struct became unused.

I don't understand why .fs (OK, .gs first) initializer was added, kernel clearly stopped touching it after the patch.

---
 arch/x86/include/asm/processor.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/x86/include/asm/processor.h +2 -1
index c2cceae..a6732ff 100644
@@ -428,7 +428,9 @@ struct thread_struct {
 	unsigned short		gsindex;
 #endif
 	unsigned long		ip;
+#ifdef CONFIG_X86_64
 	unsigned long		fs;
+#endif
 	unsigned long		gs;
 	/* Hardware debugging registers: */
 	unsigned long		debugreg0;
@@ -874,7 +876,6 @@ static inline void spin_lock_prefetch(const void *x)
 	.vm86_info		= NULL,					  \
 	.sysenter_cs		= __KERNEL_CS,				  \
 	.io_bitmap_ptr		= NULL,					  \
-	.fs			= __KERNEL_PERCPU,			  \
 }
 
 /*
#1 lore raw

[tip:x86/asm] x86, 32-bit: ifdef out struct thread_struct::fs

Commit-ID:  d756f4adb9d8a86e347a2d5435bb5cc95744733e
Gitweb:     http://git.kernel.org/tip/d756f4adb9d8a86e347a2d5435bb5cc95744733e
Author:     Alexey Dobriyan <[email protected]>
AuthorDate: Mon, 4 May 2009 03:29:52 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 11 May 2009 16:23:54 +0200

x86, 32-bit: ifdef out struct thread_struct::fs

After commit 464d1a78fbf8cf6c7fd970e7b3e2db50a320ce28 aka "[PATCH] i386: Convert i386 PDA code to use %fs"
%fs saved during context switch moved from thread_struct to pt_regs and value on thread_struct became unused.

[ Impact: reduce thread_struct size on 32-bit ]

LKML-Reference: <[email protected]>

---
 arch/x86/include/asm/processor.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/x86/include/asm/processor.h +2 -1
index c2cceae..a6732ff 100644
@@ -428,7 +428,9 @@ struct thread_struct {
 	unsigned short		gsindex;
 #endif
 	unsigned long		ip;
+#ifdef CONFIG_X86_64
 	unsigned long		fs;
+#endif
 	unsigned long		gs;
 	/* Hardware debugging registers: */
 	unsigned long		debugreg0;
@@ -874,7 +876,6 @@ static inline void spin_lock_prefetch(const void *x)
 	.vm86_info		= NULL,					  \
 	.sysenter_cs		= __KERNEL_CS,				  \
 	.io_bitmap_ptr		= NULL,					  \
-	.fs			= __KERNEL_PERCPU,			  \
 }
 
 /*