Skip to contentSkip to conversation

mm: setup_per_zone_inactive_ratio - fix comment and make it __init

PATCH In review Cyrill Gorcunov 4 participants 5 messages May 6, 2009

Subsystems (2)
Memory management Page allocator
lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 mm: setup_per_zone_inactive_ratio - fix comment and make it __init

The caller of setup_per_zone_inactive_ratio is module_init function. No need to keep the callee after is completed as well. Also fix a comment.

CC David Rientjes <[email protected]>
Signed-off-by Cyrill Gorcunov <[email protected]>
---
 mm/page_alloc.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
mm/page_alloc.c +1 -3
Index: linux-2.6.git/mm/page_alloc.c
=====================================================================
@@ -4540,8 +4540,6 @@ void setup_per_zone_pages_min(void)
 }
 
 /**
- * setup_per_zone_inactive_ratio - called when min_free_kbytes changes.
- *
  * The inactive anon list should be small enough that the VM never has to
  * do too much work, but large enough that each inactive page has a chance
  * to be referenced again before it is swapped out.

@@ -4562,7 +4560,7 @@ void setup_per_zone_pages_min(void)
  *    1TB     101        10GB
  *   10TB     320        32GB
  */
-static void setup_per_zone_inactive_ratio(void)
+static void __init setup_per_zone_inactive_ratio(void)
 {
 	struct zone *zone;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Cyrill Gorcunov

The caller of setup_per_zone_inactive_ratio is module_init function. No need to keep the callee after is completed as well. Also fix a comment.

CC David Rientjes <[email protected]>
Signed-off-by Cyrill Gorcunov <[email protected]>
Acked-by David Rientjes <[email protected]>

There's no need to specify -mmotm on the subject line since it isn't specific to that tree, this applies to HEAD just fine.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Reviewed-by on v1 1/1
#2 lore raw
In reply to Cyrill Gorcunov
Quoted 1 line · On Wed, 6 May 2009 10:19:23 +0400 Cyrill Gorcunov <[email protected]> wrote:

The caller of setup_per_zone_inactive_ratio is module_init function.

__init :)

Quoted 5 lines

No need to keep the callee after is completed as well. Also fix a comment.

CC David Rientjes <[email protected]>
Signed-off-by Cyrill Gorcunov <[email protected]>
Reviewed-by Minchan Kim <[email protected]>

I guess the comment was a typo.

Quoted 32 lines
---
 mm/page_alloc.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: linux-2.6.git/mm/page_alloc.c
=====================================================================

mm/page_alloc.c +1 -4
@@ -4540,8 +4540,6 @@ void setup_per_zone_pages_min(void)
 }
 
 /**
- * setup_per_zone_inactive_ratio - called when min_free_kbytes changes.
- *
  * The inactive anon list should be small enough that the VM never has to
  * do too much work, but large enough that each inactive page has a chance
  * to be referenced again before it is swapped out.

@@ -4562,7 +4560,7 @@ void setup_per_zone_pages_min(void)
  *    1TB     101        10GB
  *   10TB     320        32GB
  */
-static void setup_per_zone_inactive_ratio(void)
+static void __init setup_per_zone_inactive_ratio(void)
 {
 	struct zone *zone;
 
 
--

To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Signature · 8 lines
Kinds Regards
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#3 lore raw

[Minchan Kim - Wed, May 06, 2009 at 03:51:45PM +0900]

| On Wed, 6 May 2009 10:19:23 +0400
| Cyrill Gorcunov <[email protected]> wrote:
| 
| > The caller of setup_per_zone_inactive_ratio is module_init function.
| 
| __init :)
| 
| > No need to keep the callee after is completed as well.
| > Also fix a comment.
| > 
| > CC: David Rientjes <[email protected]>
| > Signed-off-by: Cyrill Gorcunov <[email protected]>
| 
| Reviewed-by: Minchan Kim <[email protected]>
| I guess the comment was a typo.

Thanks Minchan. Actually it's not a typo :) module_init function is supposed to be __initcall function anyway. But it's confusing I could fix changelog.

-- Cyrill

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#4 lore raw

[Cyrill Gorcunov - Wed, May 06, 2009 at 11:03:23AM +0400]
...

| Thanks Minchan. Actually it's not a typo :)
| module_init function is supposed to be __initcall
| function anyway. But it's confusing I could fix
| changelog.
| 
| 	-- Cyrill

Andrew, could you s/module_init/__init/ in changelog please?

-- Cyrill

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>