Skip to contentSkip to conversation

do_wait cleanupe (more to come)

PATCH In review Oleg Nesterov 3 participants 4 messages May 7, 2009 – May 11, 2009

lore
Share & tools
lore
#0 lore raw

cover do_wait cleanupe (more to come)

Slightly tested. Definitely this needs more testing, but since a) the second patch was reviewed by Ingo and b) Andrew likes the buggy patches very much, I am sending this series. At least I believe this all is right "in general".

I was going to send more cleanups (siginfo/rusage filling), but it turns out we race with Vitaly who has already started this work.

Vitaly, could you re-diff your (imho very nice) changes on top of this series?

Oleg.

#1 lore raw
Quoted 4 lines · On Thu, 7 May 2009 08:46:30 +0200 Oleg Nesterov <[email protected]> wrote:

Slightly tested. Definitely this needs more testing, but since a) the second patch was reviewed by Ingo and b) Andrew likes the buggy patches very much, I am sending this series. At least I believe this all is right "in general".

Worried. This hits on ptrace and there's a lot of ptrace work pending, including large changes which are threatening to come in via a different tree (security).

If we end up with marginal/flakey patches in the middle of all of this, a big mess ensues.

#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Thu, 7 May 2009 08:46:30 +0200 Oleg Nesterov <[email protected]> wrote:

Slightly tested. Definitely this needs more testing, but since a) the second patch was reviewed by Ingo and b) Andrew likes the buggy patches very much, I am sending this series. At least I believe this all is right "in general".

Quoted 6 lines

Worried. This hits on ptrace and there's a lot of ptrace work pending, including large changes which are threatening to come in via a different tree (security).

If we end up with marginal/flakey patches in the middle of all of this, a big mess ensues.

This problems would be solved if all these bits were in -mm.

Ingo

#3 lore raw
Quoted 11 lines · On Mon, 11 May 2009 14:22:33 +0200 Ingo Molnar <[email protected]> wrote:
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Thu, 7 May 2009 08:46:30 +0200 Oleg Nesterov <[email protected]> wrote:

Slightly tested. Definitely this needs more testing, but since a) the second patch was reviewed by Ingo and b) Andrew likes the buggy patches very much, I am sending this series. At least I believe this all is right "in general".

Quoted 9 lines
Quoted 6 lines

Worried. This hits on ptrace and there's a lot of ptrace work pending, including large changes which are threatening to come in via a different tree (security).

If we end up with marginal/flakey patches in the middle of all of this, a big mess ensues.

This problems would be solved if all these bits were in -mm.

I merged them, but that didn't solve the problem. If more ptrace work happens and then these patches turn out to be bad, we have a mess on our hands.

IOW, merging "Slightly tested. Definitely this needs more testing" patches into an area on ongoing development is a bit risky.