Skip to contentSkip to conversation

do_wait: kill the old BUG_ON, use while_each_thread()

PATCH In review Oleg Nesterov 2 participants 2 messages May 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 4/5 do_wait: kill the old BUG_ON, use while_each_thread()

do_wait() does BUG_ON(tsk->signal != current->signal), this looks like a raher obsolete check. At least, I don't think do_wait() is the best place to verify that all threads have the same ->signal. Remove it.

Also, change the code to use while_each_thread().

---

 kernel/exit.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/exit.c renamed from kernel/exit.c~4_WHILE +1 -3
@@ -1595,9 +1595,7 @@ repeat:
 
 		if (wo->wo_flags & __WNOTHREAD)
 			break;
-		tsk = next_thread(tsk);
-		BUG_ON(tsk->signal != current->signal);
-	} while (tsk != current);
+	} while_each_thread(current, tsk);
 	read_unlock(&tasklist_lock);
 
 notask: